From: Greg KH <greg@kroah.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Stefan Eichenberger <stefan.eichenberger@toradex.com>
Subject: Re: linux-next: manual merge of the tty tree with the tty.current tree
Date: Tue, 9 Jul 2024 13:04:35 +0200 [thread overview]
Message-ID: <2024070925-area-cobbler-271f@gregkh> (raw)
In-Reply-To: <20240709153747.07d7272c@canb.auug.org.au>
On Tue, Jul 09, 2024 at 03:37:47PM +1000, Stephen Rothwell wrote:
> Hi all,
>
> Today's linux-next merge of the tty tree got a conflict in:
>
> drivers/tty/serial/imx.c
>
> between commit:
>
> 9706fc87b4cf ("serial: imx: only set receiver level if it is zero")
>
> from the tty.current tree and commit:
>
> 3093f180bc6e ("serial: imx: stop casting struct uart_port to struct imx_port")
>
> from the tty tree.
>
> I fixed it up (see below) and can carry the fix as necessary. This
> is now fixed as far as linux-next is concerned, but any non trivial
> conflicts should be mentioned to your upstream maintainer when your tree
> is submitted for merging. You may also want to consider cooperating
> with the maintainer of the conflicting tree to minimise any particularly
> complex conflicts.
>
> --
> Cheers,
> Stephen Rothwell
>
> diff --cc drivers/tty/serial/imx.c
> index ff32cd2d2863,d96f0524f7fb..000000000000
> --- a/drivers/tty/serial/imx.c
> +++ b/drivers/tty/serial/imx.c
> @@@ -1549,10 -1553,9 +1554,10 @@@ static int imx_uart_startup(struct uart
>
> static void imx_uart_shutdown(struct uart_port *port)
> {
> - struct imx_port *sport = (struct imx_port *)port;
> + struct imx_port *sport = to_imx_port(port);
> unsigned long flags;
> u32 ucr1, ucr2, ucr4, uts;
> + int loops;
>
> if (sport->dma_is_enabled) {
> dmaengine_terminate_sync(sport->dma_chan_tx);
> @@@ -1984,8 -1937,8 +1989,8 @@@ static void imx_uart_poll_put_char(stru
> static int imx_uart_rs485_config(struct uart_port *port, struct ktermios *termios,
> struct serial_rs485 *rs485conf)
> {
> - struct imx_port *sport = (struct imx_port *)port;
> + struct imx_port *sport = to_imx_port(port);
> - u32 ucr2;
> + u32 ucr2, ufcr;
>
> if (rs485conf->flags & SER_RS485_ENABLED) {
> /* Enable receiver if low-active RTS signal is requested */
Looks good, thanks!
greg k-h
next prev parent reply other threads:[~2024-07-09 11:04 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-09 5:37 linux-next: manual merge of the tty tree with the tty.current tree Stephen Rothwell
2024-07-09 11:04 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-11-27 1:09 Stephen Rothwell
2025-11-27 6:52 ` Greg KH
2024-04-19 4:19 Stephen Rothwell
2024-04-19 6:09 ` Greg KH
2024-04-23 11:24 ` Greg KH
2024-04-11 3:57 Stephen Rothwell
2024-04-11 4:17 ` Stephen Rothwell
2024-04-11 4:38 ` Greg KH
2024-04-11 10:40 ` Andy Shevchenko
2023-10-04 1:55 Stephen Rothwell
2023-10-04 2:14 ` Stephen Rothwell
2023-10-04 6:38 ` Greg KH
2023-10-16 8:20 ` Greg KH
2020-09-17 6:09 Stephen Rothwell
2020-09-17 6:34 ` Greg KH
2019-12-18 0:49 Stephen Rothwell
2019-12-18 7:05 ` Greg KH
2017-08-02 4:26 Stephen Rothwell
2017-08-04 1:02 ` Greg KH
2017-08-14 22:17 ` Greg KH
2017-03-20 2:28 Stephen Rothwell
2017-03-20 9:21 ` Dmitry Vyukov
2017-03-20 9:26 ` Dmitry Vyukov
2017-03-29 5:51 ` Greg KH
2017-03-30 3:46 ` Michael Neuling
2017-03-30 12:17 ` Dmitry Vyukov
2016-02-08 2:16 Stephen Rothwell
2016-02-08 2:21 ` Greg KH
2016-02-08 2:53 ` Peter Hurley
2016-04-01 0:23 ` Peter Hurley
2016-04-01 3:49 ` Greg KH
2015-05-25 8:19 Stephen Rothwell
2015-05-25 16:28 ` Greg KH
2015-05-26 11:08 ` Dave Martin
2014-11-26 7:12 Stephen Rothwell
2014-11-26 19:51 ` Greg KH
2014-11-10 4:49 Stephen Rothwell
2014-11-10 5:08 ` Greg KH
2013-01-17 2:07 Stephen Rothwell
2013-01-18 1:27 ` Greg KH
2012-04-19 4:59 Stephen Rothwell
2012-04-19 20:07 ` Greg KH
2012-04-23 16:40 ` Greg KH
2011-11-18 3:30 Stephen Rothwell
2011-11-18 8:41 ` Jiri Slaby
2011-11-18 16:18 ` Greg KH
2011-11-27 4:08 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024070925-area-cobbler-271f@gregkh \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=sfr@canb.auug.org.au \
--cc=stefan.eichenberger@toradex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.