Re: [Buildroot] [PATCH] package/sqlitecpp: new package

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Michael Nosthoff via buildroot <buildroot@buildroot.org>
Cc: Samuel Martin <s.martin49@gmail.com>
Subject: Re: [Buildroot] [PATCH] package/sqlitecpp: new package
Date: Wed, 10 Jul 2024 10:48:42 +0200	[thread overview]
Message-ID: <20240710104842.16dbf85c@windsurf> (raw)
In-Reply-To: <20240710081348.60978-1-buildroot@heine.tech>

Hello Michael,

On Wed, 10 Jul 2024 10:13:47 +0200
Michael Nosthoff via buildroot <buildroot@buildroot.org> wrote:

> SQLiteC++ (SQLiteCpp) is a lean and easy to use C++ SQLite3 wrapper.
> 
> http://srombauts.github.io/SQLiteCpp/
> 
> Signed-off-by: Michael Nosthoff <buildroot@heine.tech>

Thanks, I have applied after doing some changes, see below.

> diff --git a/package/sqlitecpp/Config.in b/package/sqlitecpp/Config.in
> new file mode 100644
> index 0000000000..02b2d8989c
> --- /dev/null
> +++ b/package/sqlitecpp/Config.in
> @@ -0,0 +1,9 @@
> +config BR2_PACKAGE_SQLITECPP
> +	bool "SQLiteC++"

Changed to:

	bool "sqlitecpp"

Indeed, we really want the prompt to be the same as the package name.

> +	select BR2_PACKAGE_SQLITE
> +	select BR2_PACKAGE_SQLITE_ENABLE_COLUMN_METADATA

Since it's written in C++, you forgot:

	depends on BR2_INSTALL_LIBSDCPP

and the corresponding Config.in comment saying that the toolchain needs
to have C++ support.

> diff --git a/package/sqlitecpp/sqlitecpp.mk b/package/sqlitecpp/sqlitecpp.mk
> new file mode 100644
> index 0000000000..bb1caa0f39
> --- /dev/null
> +++ b/package/sqlitecpp/sqlitecpp.mk
> @@ -0,0 +1,20 @@
> +################################################################################
> +#
> +# SQLiteC++
> +#
> +################################################################################
> +
> +SQLITECPP_VERSION = 3.3.1
> +SQLITECPP_SOURCE = $(SQLITECPP_VERSION).tar.gz

This _SOURCE variable was not needed, the default is good enough.

> +SQLITECPP_SITE = $(call github,SRombauts,SQLiteCpp,$(SQLITECPP_VERSION))
> +SQLITECPP_LICENSE = MIT
> +SQLITECPP_LICENSE_FILES = LICENSE.txt
> +SQLITECPP_DEPENDENCIES = sqlite
> +SQLITECPP_INSTALL_STAGING = YES
> +
> +SQLITECPP_CONF_OPTS = \
> +	-DSQLITECPP_INTERNAL_SQLITE=OFF \
> +	-DSQLITECPP_RUN_CPPLINT=OFF \
> +	-DSQLITECPP_RUN_CPPCHECK=OFF
> +
> +$(eval $(cmake-package))

Again: applied with those changes. Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot