From: Kent Gibson <warthog618@gmail.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [libgpiod][PATCH v3 0/2] bindings: python: fix line request by name with multiple entries
Date: Wed, 10 Jul 2024 21:34:53 +0800 [thread overview]
Message-ID: <20240710133453.GA108376@rigel> (raw)
In-Reply-To: <20240710125719.33655-1-brgl@bgdev.pl>
On Wed, Jul 10, 2024 at 02:57:17PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> We haven't heard from Chuang in two weeks but I want to finalize this
> series so I applied the hints from Kent.
>
> Changes in v3:
> - tweak the commit messages
> - change the test class name
> - improve the test case by testing one more line name
>
> Chuang Zhu (2):
> bindings: python: fix line request by name with multiple entries
> bindings: python: tests: add a new test case
>
I prefer adding the test case first, to demonstrate the problem before
fixing it, but it isn't a deal breaker.
Other than that, looks good to me.
Reviewed-by: Kent Gibson <warthog618@gmail.com>
for the series.
next prev parent reply other threads:[~2024-07-10 13:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-10 12:57 [libgpiod][PATCH v3 0/2] bindings: python: fix line request by name with multiple entries Bartosz Golaszewski
2024-07-10 12:57 ` [libgpiod][PATCH v3 1/2] " Bartosz Golaszewski
2024-07-10 12:57 ` [libgpiod][PATCH v3 2/2] bindings: python: tests: add a new test case Bartosz Golaszewski
2024-07-10 13:34 ` Kent Gibson [this message]
2024-07-11 11:26 ` [libgpiod][PATCH v3 0/2] bindings: python: fix line request by name with multiple entries Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240710133453.GA108376@rigel \
--to=warthog618@gmail.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.