From: Petr Vorel <pvorel@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3 2/4] Add lstat03 test
Date: Wed, 10 Jul 2024 16:53:32 +0200 [thread overview]
Message-ID: <20240710145332.GB295483@pevik> (raw)
In-Reply-To: <20240710-stat04-v3-2-c68a2324ad94@suse.com>
Hi Andrea,
the same note as for stat04 - this could be using all_filesystems,
but let's do it as a separate effort.
...
> +static void cleanup(void)
> +{
> + if (access(SYMBNAME, F_OK) != -1)
> + SAFE_UNLINK(SYMBNAME);
nit: This is not needed (file created at setup).
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-07-10 14:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-10 8:54 [LTP] [PATCH v3 0/4] symlink01 split Andrea Cervesato
2024-07-10 8:54 ` [LTP] [PATCH v3 1/4] Add stat04 test Andrea Cervesato
2024-07-10 12:15 ` Cyril Hrubis
2024-07-10 14:44 ` Petr Vorel
2024-07-10 15:14 ` Petr Vorel
2024-07-10 8:54 ` [LTP] [PATCH v3 2/4] Add lstat03 test Andrea Cervesato
2024-07-10 14:53 ` Petr Vorel [this message]
2024-07-10 8:54 ` [LTP] [PATCH v3 3/4] Add chmod08 test Andrea Cervesato
2024-07-10 15:12 ` Petr Vorel
2024-07-10 8:54 ` [LTP] [PATCH v3 4/4] Add open15 test Andrea Cervesato
2024-07-10 9:37 ` Li Wang
2024-07-10 14:39 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240710145332.GB295483@pevik \
--to=pvorel@suse.cz \
--cc=andrea.cervesato@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.