From: Jakub Kicinski <kuba@kernel.org>
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: Peng Fan <peng.fan@nxp.com>,
"Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
"virtualization@lists.linux.dev" <virtualization@lists.linux.dev>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] test/vsock: add install target
Date: Wed, 10 Jul 2024 19:00:59 -0700 [thread overview]
Message-ID: <20240710190059.06f01a4c@kernel.org> (raw)
In-Reply-To: <whgbeixcinqi2dmcfxxy4h7xfzjjx3kpsqsmjiffkkaijlxh6i@ozhumbrjse3c>
On Wed, 10 Jul 2024 13:58:39 +0200 Stefano Garzarella wrote:
> There is a comment there:
>
> # Avoid changing the rest of the logic here and lib.mk.
>
> Added by commit 17eac6c2db8b2cdfe33d40229bdda2acd86b304a.
>
> IIUC they re-used INSTALL_PATH, just to avoid too many changes in that
> file and in tools/testing/selftests/lib.mk
>
> So, IMHO we should not care about it and only use VSOCK_INSTALL_PATH if
> you don't want to conflict with INSTALL_PATH.
Any reason why vsock isn't part of selftests in the first place?
next prev parent reply other threads:[~2024-07-11 2:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-09 13:50 [PATCH] test/vsock: add install target Peng Fan (OSS)
2024-07-10 7:34 ` Stefano Garzarella
2024-07-10 8:11 ` Peng Fan
2024-07-10 9:11 ` Stefano Garzarella
2024-07-10 11:34 ` Peng Fan
2024-07-10 11:58 ` Stefano Garzarella
2024-07-11 2:00 ` Jakub Kicinski [this message]
2024-07-11 7:07 ` Stefano Garzarella
2024-07-11 13:38 ` Stefan Hajnoczi
2024-07-11 14:14 ` Jakub Kicinski
2024-07-12 8:53 ` Stefano Garzarella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240710190059.06f01a4c@kernel.org \
--to=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=peng.fan@oss.nxp.com \
--cc=sgarzare@redhat.com \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.