From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: "Gero Schwäricke via buildroot" <buildroot@buildroot.org>
Cc: "Xuanhao Shi" <X15000177@gmail.com>,
"Gero Schwäricke" <gero.schwaericke@grandcentrix.net>,
"Bryan Brattlof" <bb@ti.com>, "Anand Gadiyar" <gadiyar@ti.com>
Subject: Re: [Buildroot] [PATCH 1/2] board/ti/am62x-sk: update custom hashes
Date: Wed, 10 Jul 2024 23:30:14 +0200 [thread overview]
Message-ID: <20240710233014.16677ba1@windsurf> (raw)
In-Reply-To: <20240620110905.1205820-2-gero.schwaericke@grandcentrix.net>
On Thu, 20 Jun 2024 13:08:20 +0200
Gero Schwäricke via buildroot <buildroot@buildroot.org> wrote:
> Signed-off-by: Gero Schwäricke <gero.schwaericke@grandcentrix.net>
> ---
> .../patches/arm-trusted-firmware/arm-trusted-firmware.hash | 2 +-
> .../ti/am62x-sk/patches/ti-k3-r5-loader/ti-k3-r5-loader.hash | 4 ++--
> board/ti/am62x-sk/patches/uboot/uboot.hash | 4 ++--
> 3 files changed, 5 insertions(+), 5 deletions(-)
Thanks for your two patches. They are both correct indeed, but the
commit log should have explained what happened. So here is what I added
(so that you can see the sort of explanation we expect to see in commit
logs):
board/ti/am62x-sk: update custom hashes
Commit
cc2910a7dbd331ae0ad6a8f06ce7cd0559a1ebe1 ("configs/ti_am62x_sk_defconfig:
update U-Boot to v2024.04") updated U-Boot and the ti-k3-r5-loader to
2024.04, but did not update the hash files in board/ti/am62x-sk/. It
ended up working for now, because the official versions of boot/uboot
and boot/ti-k3-r5-loader/ also use 2024.04 and therefore have this
hash, but it would have started failing as soon as boot/uboot and/or
boot/ti-k3-r5-loader official version were updated.
Signed-off-by: Gero Schwäricke <gero.schwaericke@grandcentrix.net>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Both patches applied with those improved commit messages. Thanks again!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-07-10 21:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-20 11:08 [Buildroot] [PATCH 0/2] board/ti/am6{2, 4}x-sk: update custom hashes Gero Schwäricke via buildroot
2024-06-20 11:08 ` [Buildroot] [PATCH 1/2] board/ti/am62x-sk: " Gero Schwäricke via buildroot
2024-07-10 21:30 ` Thomas Petazzoni via buildroot [this message]
2024-07-28 7:17 ` Peter Korsgaard
2024-06-20 11:08 ` [Buildroot] [PATCH 2/2] board/ti/am64x-sk: " Gero Schwäricke via buildroot
2024-06-20 15:41 ` [Buildroot] [PATCH 0/2] board/ti/am6{2, 4}x-sk: " Bryan Brattlof via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240710233014.16677ba1@windsurf \
--to=buildroot@buildroot.org \
--cc=X15000177@gmail.com \
--cc=bb@ti.com \
--cc=gadiyar@ti.com \
--cc=gero.schwaericke@grandcentrix.net \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.