From: Greg KH <gregkh@linuxfoundation.org>
To: 李哲 <sensor1010@163.com>
Cc: rafael@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] driver:core: no need to set a default value for want_async
Date: Thu, 11 Jul 2024 17:13:21 +0200 [thread overview]
Message-ID: <2024071101-cytoplast-overflow-d8cd@gregkh> (raw)
In-Reply-To: <20240711150545.3143-1-sensor1010@163.com>
On Thu, Jul 11, 2024 at 08:05:45AM -0700, 李哲 wrote:
> The default value of this member variable is false,
> which is only set to true when asynchronous loading is required,
> and does not need to be set to false during synchronization
>
> Signed-off-by: 李哲 <sensor1010@163.com>
> ---
> drivers/base/dd.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/base/dd.c b/drivers/base/dd.c
> index d047919d1f5e..47351d98f6e1 100644
> --- a/drivers/base/dd.c
> +++ b/drivers/base/dd.c
> @@ -1014,7 +1014,6 @@ static int __device_attach(struct device *dev, bool allow_async)
> struct device_attach_data data = {
> .dev = dev,
> .check_async = allow_async,
> - .want_async = false,
This is good to keep as-is for documentation alone, it doesn't actually
change anything and makes it obvious.
thanks,
greg k-h
prev parent reply other threads:[~2024-07-11 15:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-11 15:05 [PATCH] driver:core: no need to set a default value for want_async 李哲
2024-07-11 15:13 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024071101-cytoplast-overflow-d8cd@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=sensor1010@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.