All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Cornelia Huck" <cohuck@redhat.com>,
	"Matias Ezequiel Vara Larsen" <mvaralar@redhat.com>,
	virtio-comment@lists.linux.dev,
	"Vincent Guittot" <vincent.guittot@linaro.org>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Manos Pitsidianakis" <manos.pitsidianakis@linaro.org>,
	"Parav Pandit" <parav@nvidia.com>
Subject: Re: [PATCH V6] virtio-transport: Add a new section to clarify transport requirements
Date: Thu, 11 Jul 2024 03:34:45 -0400	[thread overview]
Message-ID: <20240711033414-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20240711072128.ptal2sigsg5cu3dv@vireshk-i7>

On Thu, Jul 11, 2024 at 12:51:28PM +0530, Viresh Kumar wrote:
> On 26-06-24, 08:11, Viresh Kumar wrote:
> > On 25-06-24, 16:51, Matias Ezequiel Vara Larsen wrote:
> > > > +\section{Device Requirements}\label{sec:Creating New Transports / Device Requirements}
> > > > +
> > > > +The device keeps any data associated with a device-initiated transaction
> > > > +accessible to the driver until the driver acknowledges the transaction
> > > > +to be complete.
> > > > +
> > > > +The device doesn't access the contents of a virtqueue before the driver
> > > > +notifies, in a transport defined way, the device that the virtqueue is
> > > > +ready to be accessed.
> > > > +
> > > > +The device doesn't access or modify buffers on a virtqueue after it has
> > > > +notified the driver about their availability.
> > > > +
> > > 
> > > Why are the last two requirements in this section? Are not these
> > > requirements independent of the transport layer?
> > 
> > Hmm, maybe you are right. Cornelia ?
> 
> Hi Michael / Cornelia,
> 
> Can we please get this merged a bit sooner ? It has taken a huge
> amount of time to get this upstream. I posted the first version on
> 5th December :(
> 
> Please see if we can get done with it a bit sooner. Thanks.

Iterate faster then.
Are you going to address Matias's comments?

-- 
MST


  reply	other threads:[~2024-07-11  7:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-25  7:13 [PATCH V6] virtio-transport: Add a new section to clarify transport requirements Viresh Kumar
2024-06-25 14:51 ` Matias Ezequiel Vara Larsen
2024-06-26  2:41   ` Viresh Kumar
2024-07-11  7:21     ` Viresh Kumar
2024-07-11  7:34       ` Michael S. Tsirkin [this message]
2024-07-11  7:48         ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240711033414-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=cohuck@redhat.com \
    --cc=manos.pitsidianakis@linaro.org \
    --cc=mvaralar@redhat.com \
    --cc=parav@nvidia.com \
    --cc=vincent.guittot@linaro.org \
    --cc=viresh.kumar@linaro.org \
    --cc=virtio-comment@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.