Re: [PATCH] xfs: update XFS_IOC_DIOINFO memory alignment value

["Darrick J. Wong" <djwong@kernel.org>]

On Wed, Jul 10, 2024 at 09:03:15PM -0700, Christoph Hellwig wrote:
> On Wed, Jul 10, 2024 at 07:52:06PM -0700, Darrick J. Wong wrote:
> > > -		da.d_mem =  da.d_miniosz = target->bt_logical_sectorsize;
> > > +		da.d_mem = bdev_dma_alignment(target->bt_bdev);
> > 
> > bdev_dma_alignment returns a mask, so I think you want to add one here?
> 
> Yes.
> 
> > Though at this point, perhaps DIOINFO should query the STATX_DIOALIGN
> > information so xfs doesn't have to maintain this anymore?
> > 
> > (Or just make a helper that statx and DIOINFO can both call?)
> 
> Lift DIOINFO to the VFS and back it using the statx data?

<shrug> Is there anything that DIOINFO provides that statx doesn't?
AFAICT XFS is the only fs that implements DIOINFO, so why expand that?

--D