From: "Marek Behún" <kabel@kernel.org>
To: "Andrew Lunn" <andrew@lunn.ch>,
"Gregory Clement" <gregory.clement@bootlin.com>,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org, arm@kernel.org,
"Andy Shevchenko" <andy@kernel.org>,
"Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: "Marek Behún" <kabel@kernel.org>
Subject: [PATCH 07/10] irqchip/armada-370-xp: Don't read number of supported interrupts multiple times
Date: Thu, 11 Jul 2024 13:57:45 +0200 [thread overview]
Message-ID: <20240711115748.30268-8-kabel@kernel.org> (raw)
In-Reply-To: <20240711115748.30268-1-kabel@kernel.org>
Get the number of supported interrupts, originally from the
MPIC_INT_CONTROL register, from the mpic_domain structure member when it
is already initialized.
Signed-off-by: Marek Behún <kabel@kernel.org>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
---
drivers/irqchip/irq-armada-370-xp.c | 12 ++----------
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/drivers/irqchip/irq-armada-370-xp.c b/drivers/irqchip/irq-armada-370-xp.c
index ab18dae174a8..151f0fd0389a 100644
--- a/drivers/irqchip/irq-armada-370-xp.c
+++ b/drivers/irqchip/irq-armada-370-xp.c
@@ -508,13 +508,7 @@ static int mpic_set_affinity(struct irq_data *d, const struct cpumask *mask_val,
static void mpic_smp_cpu_init(void)
{
- u32 control;
- int nr_irqs;
-
- control = readl(main_int_base + MPIC_INT_CONTROL);
- nr_irqs = (control >> 2) & 0x3ff;
-
- for (int i = 0; i < nr_irqs; i++)
+ for (int i = 0; i < mpic_domain->hwirq_max; i++)
writel(i, per_cpu_int_base + MPIC_INT_SET_MASK);
if (!mpic_is_ipi_available())
@@ -723,11 +717,9 @@ static int mpic_suspend(void)
static void mpic_resume(void)
{
bool src0, src1;
- int nirqs;
/* Re-enable interrupts */
- nirqs = (readl(main_int_base + MPIC_INT_CONTROL) >> 2) & 0x3ff;
- for (irq_hw_number_t irq = 0; irq < nirqs; irq++) {
+ for (irq_hw_number_t irq = 0; irq < mpic_domain->hwirq_max; irq++) {
struct irq_data *data;
unsigned int virq;
--
2.44.2
next prev parent reply other threads:[~2024-07-11 12:00 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-11 11:57 [PATCH 00/10] armada-370-xp irqchip updates round 3 Marek Behún
2024-07-11 11:57 ` [PATCH 01/10] irqchip/armada-370-xp: Rename variable for consistency Marek Behún
2024-07-11 14:24 ` Andrew Lunn
2024-07-29 9:49 ` [tip: irq/core] " tip-bot2 for Marek Behún
2024-07-30 11:40 ` tip-bot2 for Marek Behún
2024-07-11 11:57 ` [PATCH 02/10] irqchip/armada-370-xp: Use unsigned int type for virqs Marek Behún
2024-07-11 14:24 ` Andrew Lunn
2024-07-29 9:49 ` [tip: irq/core] " tip-bot2 for Marek Behún
2024-07-30 11:40 ` tip-bot2 for Marek Behún
2024-07-11 11:57 ` [PATCH 03/10] irqchip/armada-370-xp: Use !virq instead of virq == 0 in condition Marek Behún
2024-07-11 14:25 ` Andrew Lunn
2024-07-29 9:49 ` [tip: irq/core] " tip-bot2 for Marek Behún
2024-07-30 11:40 ` tip-bot2 for Marek Behún
2024-07-11 11:57 ` [PATCH 04/10] irqchip/armada-370-xp: Simplify ipi_resume() code Marek Behún
2024-07-11 14:25 ` Andrew Lunn
2024-07-29 9:49 ` [tip: irq/core] " tip-bot2 for Marek Behún
2024-07-30 11:40 ` tip-bot2 for Marek Behún
2024-07-11 11:57 ` [PATCH 05/10] irqchip/armada-370-xp: Improve indentation Marek Behún
2024-07-11 14:27 ` Andrew Lunn
2024-07-29 9:49 ` [tip: irq/core] " tip-bot2 for Marek Behún
2024-07-30 11:40 ` tip-bot2 for Marek Behún
2024-07-11 11:57 ` [PATCH 06/10] irqchip/armada-370-xp: Change symbol prefixes to mpic Marek Behún
2024-07-29 9:49 ` [tip: irq/core] " tip-bot2 for Marek Behún
2024-07-30 7:56 ` Marek Behún
2024-07-30 11:40 ` tip-bot2 for Marek Behún
2024-07-11 11:57 ` Marek Behún [this message]
2024-07-29 9:49 ` [tip: irq/core] irqchip/armada-370-xp: Don't read number of supported interrupts multiple times tip-bot2 for Marek Behún
2024-07-30 11:40 ` tip-bot2 for Marek Behún
2024-07-11 11:57 ` [PATCH 08/10] irqchip/armada-370-xp: Use FIELD_GET() and named register constant Marek Behún
2024-07-11 14:28 ` Andrew Lunn
2024-07-29 9:49 ` [tip: irq/core] " tip-bot2 for Marek Behún
2024-07-30 11:40 ` tip-bot2 for Marek Behún
2024-07-11 11:57 ` [PATCH 09/10] irqchip/armada-370-xp: Refactor mpic_handle_msi_irq() code Marek Behún
2024-07-11 14:29 ` Andrew Lunn
2024-07-29 9:49 ` [tip: irq/core] " tip-bot2 for Marek Behún
2024-07-30 11:40 ` tip-bot2 for Marek Behún
2024-07-11 11:57 ` [PATCH 10/10] irqchip/armada-370-xp: Refactor handling IPI interrupts Marek Behún
2024-07-11 14:29 ` Andrew Lunn
2024-07-29 9:49 ` [tip: irq/core] " tip-bot2 for Marek Behún
2024-07-30 11:39 ` tip-bot2 for Marek Behún
2024-07-11 14:10 ` [PATCH 00/10] armada-370-xp irqchip updates round 3 Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240711115748.30268-8-kabel@kernel.org \
--to=kabel@kernel.org \
--cc=andrew@lunn.ch \
--cc=andy@kernel.org \
--cc=arm@kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.