All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@lists.linux.dev
Cc: Steve Schrock <steve.schrock@getcruise.com>
Subject: [PATCH v2 01/11] udevng: Remove gps from setup_gobi
Date: Thu, 11 Jul 2024 11:46:18 -0500	[thread overview]
Message-ID: <20240711164654.1688558-1-denkenz@gmail.com> (raw)

From: Steve Schrock <steve.schrock@getcruise.com>

Even when the gps variable was set, it was not actually used for
anything.
---
 plugins/udevng.c | 14 +-------------
 1 file changed, 1 insertion(+), 13 deletions(-)

diff --git a/plugins/udevng.c b/plugins/udevng.c
index 8e116c6605ea..1c56e2ea62d3 100644
--- a/plugins/udevng.c
+++ b/plugins/udevng.c
@@ -355,7 +355,6 @@ static gboolean setup_gobi(struct modem_info *modem)
 {
 	const struct device_info *qmi = NULL;
 	const struct device_info *net = NULL;
-	const char *gps = NULL;
 	GSList *list;
 
 	DBG("%s", modem->syspath);
@@ -373,23 +372,12 @@ static gboolean setup_gobi(struct modem_info *modem)
 			qmi = info;
 		else if (g_strcmp0(subsystem, "net") == 0) /* wwan */
 			net = info;
-		else if (g_strcmp0(subsystem, "tty") == 0) {
-			if (g_strcmp0(info->interface, "255/255/255") == 0) {
-				if (g_strcmp0(info->number, "03") == 0)
-					gps = info->devnode; /* gobi */
-			} else if (g_strcmp0(info->interface, "255/0/0") == 0) {
-				if (g_strcmp0(info->number, "01") == 0)
-					gps = info->devnode; /* ec20 */
-				/* ignore the 3rd device second AT/mdm iface */
-			}
-		}
 	}
 
 	if (qmi == NULL || net == NULL)
 		return FALSE;
 
-	DBG("qmi=%s net=%s gps=%s",
-			qmi->devnode, get_ifname(net), gps);
+	DBG("qmi=%s net=%s", qmi->devnode, get_ifname(net));
 
 	if (setup_qmi_qmux(modem, qmi, net) < 0)
 		return FALSE;
-- 
2.45.2


             reply	other threads:[~2024-07-11 16:46 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-11 16:46 Denis Kenzior [this message]
2024-07-11 16:46 ` [PATCH v2 02/11] build: Require at least version 0.67 when building with external ELL Denis Kenzior
2024-07-11 16:46 ` [PATCH v2 03/11] Release 2.9 Denis Kenzior
2024-07-11 16:46 ` [PATCH v2 04/11] gobi: Limit number of premultiplexed contexts to 4 Denis Kenzior
2024-07-11 16:50   ` Denis Kenzior
2024-07-11 16:46 ` [PATCH v2 05/11] gobi: Request dedicated WDS services for contexts Denis Kenzior
2024-07-11 16:46 ` [PATCH v2 06/11] qmi: Enable _auto_ use for some classes Denis Kenzior
2024-07-11 16:46 ` [PATCH v2 07/11] qmi: gprs-context: Declare qmi_service objects using _auto_ Denis Kenzior
2024-07-11 16:46 ` [PATCH v2 08/11] qmi: Pass two dedicated WDS services to gprs-context Denis Kenzior
2024-07-11 16:46 ` [PATCH v2 09/11] qmi: gprs-context: Remove parsing of unused TLVs Denis Kenzior
2024-07-11 16:46 ` [PATCH v2 10/11] qmi: gprs-context: Treat IP family TLV as mandatory Denis Kenzior
2024-07-11 16:46 ` [PATCH v2 11/11] qmi: gprs-context: Set up WDS service for IPv6 Denis Kenzior
2024-07-11 17:53 ` [PATCH v2 01/11] udevng: Remove gps from setup_gobi patchwork-bot+ofono

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240711164654.1688558-1-denkenz@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@lists.linux.dev \
    --cc=steve.schrock@getcruise.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.