From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
John Garry <john.g.garry@oracle.com>,
Will Deacon <will@kernel.org>, James Clark <james.clark@arm.com>,
Mike Leach <mike.leach@linaro.org>, Leo Yan <leo.yan@linux.dev>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Yicong Yang <yangyicong@hisilicon.com>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
Nick Terrell <terrelln@fb.com>,
Nick Desaulniers <ndesaulniers@google.com>,
Oliver Upton <oliver.upton@linux.dev>,
Anshuman Khandual <anshuman.khandual@arm.com>,
Song Liu <song@kernel.org>,
Ilkka Koskinen <ilkka@os.amperecomputing.com>,
Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
Huacai Chen <chenhuacai@kernel.org>,
Yanteng Si <siyanteng@loongson.cn>,
Sun Haiyong <sunhaiyong@loongson.cn>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 25/28] perf test event_update: Ensure tools is initialized
Date: Thu, 11 Jul 2024 11:00:05 -0700 [thread overview]
Message-ID: <20240711180008.188906-26-irogers@google.com> (raw)
In-Reply-To: <20240711180008.188906-1-irogers@google.com>
Ensure tool is initialized to avoid lazy initialization pattern so
that more uses of struct perf_tool can be made const.
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/tests/event_update.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/perf/tests/event_update.c b/tools/perf/tests/event_update.c
index fdecad920f59..d6b4ce3ef4ee 100644
--- a/tools/perf/tests/event_update.c
+++ b/tools/perf/tests/event_update.c
@@ -103,6 +103,7 @@ static int test__event_update(struct test_suite *test __maybe_unused, int subtes
TEST_ASSERT_VAL("failed to synthesize attr update scale",
!perf_event__synthesize_event_update_scale(NULL, evsel, process_event_scale));
+ perf_tool__init(&tmp.tool, /*ordered_events=*/false);
tmp.name = evsel__name(evsel);
TEST_ASSERT_VAL("failed to synthesize attr update name",
--
2.45.2.993.g49e7a77208-goog
next prev parent reply other threads:[~2024-07-11 18:01 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-11 17:59 [PATCH v4 00/28] Constify tool pointers Ian Rogers
2024-07-11 17:59 ` [PATCH v4 01/28] perf auxtrace: Remove dummy tools Ian Rogers
2024-07-11 17:59 ` [PATCH v4 02/28] perf s390-cpumsf: Remove unused struct Ian Rogers
2024-07-11 17:59 ` [PATCH v4 03/28] perf cs-etm: Fix address sanitizer dso build failure Ian Rogers
2024-07-11 17:59 ` [PATCH v4 04/28] perf tool: Constify tool pointers Ian Rogers
2024-07-11 17:59 ` [PATCH v4 05/28] perf tool: Move fill defaults into tool.c Ian Rogers
2024-07-11 17:59 ` [PATCH v4 06/28] perf tool: Add perf_tool__init Ian Rogers
2024-07-11 17:59 ` [PATCH v4 07/28] perf kmem: Use perf_tool__init Ian Rogers
2024-07-11 17:59 ` [PATCH v4 08/28] perf buildid-list: " Ian Rogers
2024-07-11 17:59 ` [PATCH v4 09/28] perf kvm: " Ian Rogers
2024-07-11 17:59 ` [PATCH v4 10/28] perf lock: " Ian Rogers
2024-07-11 17:59 ` [PATCH v4 11/28] perf evlist: " Ian Rogers
2024-07-11 17:59 ` [PATCH v4 12/28] perf record: " Ian Rogers
2024-07-11 17:59 ` [PATCH v4 13/28] perf c2c: " Ian Rogers
2024-07-11 17:59 ` [PATCH v4 14/28] perf script: " Ian Rogers
2024-07-11 17:59 ` [PATCH v4 15/28] perf inject: " Ian Rogers
2024-07-11 17:59 ` [PATCH v4 16/28] perf report: " Ian Rogers
2024-07-11 17:59 ` [PATCH v4 17/28] perf stat: " Ian Rogers
2024-07-11 17:59 ` [PATCH v4 18/28] perf annotate: " Ian Rogers
2024-07-11 17:59 ` [PATCH v4 19/28] perf sched: " Ian Rogers
2024-07-11 18:00 ` [PATCH v4 20/28] perf mem: " Ian Rogers
2024-07-11 18:00 ` [PATCH v4 21/28] perf timechart: " Ian Rogers
2024-07-11 18:00 ` [PATCH v4 22/28] perf diff: " Ian Rogers
2024-07-11 18:00 ` [PATCH v4 23/28] perf data convert json: " Ian Rogers
2024-07-11 18:00 ` [PATCH v4 24/28] perf data convert ctf: " Ian Rogers
2024-07-11 18:00 ` Ian Rogers [this message]
2024-07-11 18:00 ` [PATCH v4 26/28] perf kwork: " Ian Rogers
2024-07-11 18:00 ` [PATCH v4 27/28] perf tool: Remove perf_tool__fill_defaults Ian Rogers
2024-07-11 18:00 ` [PATCH v4 28/28] perf session: Constify tool Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240711180008.188906-26-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=anshuman.khandual@arm.com \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=chenhuacai@kernel.org \
--cc=ilkka@os.amperecomputing.com \
--cc=james.clark@arm.com \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=jonathan.cameron@huawei.com \
--cc=kan.liang@linux.intel.com \
--cc=leo.yan@linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=ndesaulniers@google.com \
--cc=oliver.upton@linux.dev \
--cc=peterz@infradead.org \
--cc=siyanteng@loongson.cn \
--cc=song@kernel.org \
--cc=sunhaiyong@loongson.cn \
--cc=suzuki.poulose@arm.com \
--cc=terrelln@fb.com \
--cc=will@kernel.org \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.