From: Jakub Kicinski <kuba@kernel.org>
To: Breno Leitao <leitao@debian.org>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
thepacketgeek@gmail.com, riel@surriel.com, horms@kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 3/3] net: netconsole: Disable target before netpoll cleanup
Date: Thu, 11 Jul 2024 18:32:22 -0700 [thread overview]
Message-ID: <20240711183222.0d7e33fd@kernel.org> (raw)
In-Reply-To: <20240709144403.544099-4-leitao@debian.org>
On Tue, 9 Jul 2024 07:44:01 -0700 Breno Leitao wrote:
> Currently, netconsole cleans up the netpoll structure before disabling
> the target. This approach can lead to race conditions, as message
> senders (write_ext_msg() and write_msg()) check if the target is
> enabled before using netpoll.
>
> This patch reverses the order of operations:
> 1. Disable the target
> 2. Clean up the netpoll structure
>
> This change eliminates the potential race condition, ensuring that
> no messages are sent through a partially cleaned-up netpoll structure.
I think this is a legit fix, please add a Fixes tag and resend for net.
next prev parent reply other threads:[~2024-07-12 1:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-09 14:43 [PATCH net-next 0/3] netconsole: Fix potential race condition and improve code clarity Breno Leitao
2024-07-09 14:43 ` [PATCH net-next 1/3] net: netconsole: Remove unnecessary cast from bool Breno Leitao
2024-07-09 14:44 ` [PATCH net-next 2/3] net: netconsole: Eliminate redundant setting of enabled field Breno Leitao
2024-07-09 14:44 ` [PATCH net-next 3/3] net: netconsole: Disable target before netpoll cleanup Breno Leitao
2024-07-12 1:32 ` Jakub Kicinski [this message]
2024-07-12 2:00 ` [PATCH net-next 0/3] netconsole: Fix potential race condition and improve code clarity patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240711183222.0d7e33fd@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=riel@surriel.com \
--cc=thepacketgeek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.