Re: [Buildroot] [PATCH] package/systemd: Add BCACHEFS superblock magic

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Jarkko Sakkinen <jarkko@kernel.org>
Cc: Sen Hastings <sen@hastings.org>,
	Norbert Lange <nolange79@gmail.com>,
	"Yann E . MORIN" <yann.morin.1998@free.fr>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/systemd: Add BCACHEFS superblock magic
Date: Fri, 12 Jul 2024 00:28:13 +0200	[thread overview]
Message-ID: <20240712002813.1a9e7f2a@windsurf> (raw)
In-Reply-To: <20240611165539.658551-1-jarkko@kernel.org>

Hello Jarkko,

On Tue, 11 Jun 2024 19:55:39 +0300
Jarkko Sakkinen <jarkko@kernel.org> wrote:

> Add the magic number for the bcachefs superblock. Otherwise, systemd
> 254.13 fails to compile with the latest kernel versions.
> 
> Upstream commit ID:  201148b08de6 ("basic: Add BCACHEFS magic")
> 
> Cc: Norbert Lange <nolange79@gmail.com>
> Cc: Sen Hastings <sen@hastings.org>
> Cc: Yann E. MORIN <yann.morin.1998@free.fr>
> Link: https://social.kernel.org/notice/Aie4Z8s4zYztoFTWUq
> Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>

Thanks for the patch, which I have applied, after fixing a few things,
see below.

> diff --git a/package/systemd/0001-basic-add-bcachefs-magic.patch b/package/systemd/0001-basic-add-bcachefs-magic.patch
> new file mode 100644
> index 0000000000..ca13067f6a
> --- /dev/null
> +++ b/package/systemd/0001-basic-add-bcachefs-magic.patch
> @@ -0,0 +1,50 @@
> +From e5ff9b585d7dc54f50085d518d7d588c250b0690 Mon Sep 17 00:00:00 2001
> +From: Chris Packham <chris.packham@alliedtelesis.co.nz>
> +Date: Fri, 31 May 2024 09:51:38 +1200
> +Subject: [PATCH 2/2] basic: Add BCACHEFS magic

We don't want the 2/2 in our patches, because it always becomes out of
date very quickly.

> +
> +Import magic.h from Linux 6.9 to get the definition of
> +BCACHEFS_SUPER_MAGIC. Update filesystems-gperf.gperf to add knowledge of
> +bcachefs.
> +
> +This fixes the following error building against a bleeding edge kernel.
> +```
> +src/basic/meson.build:234:8: ERROR: Problem encountered: Unknown filesystems defined in kernel headers:
> +
> +Filesystem found in kernel header but not in filesystems-gperf.gperf: BCACHEFS_SUPER_MAGIC
> +```

Missing Upstream: tag, missing Signed-off-by: tag.

All 3 issues are reported by "make check-package".

I fixed them when applying your patch to master, and also improved a
bit the commit title/message.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot