Re: [Buildroot] [PATCH] package/mpd: fix build with fmt 11

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Andreas Ziegler <br015@umbiko.net>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/mpd: fix build with fmt 11
Date: Fri, 12 Jul 2024 08:47:43 +0200	[thread overview]
Message-ID: <20240712084743.0da3c657@windsurf> (raw)
In-Reply-To: <20240712053614.733789-1-br015@umbiko.net>

Hello Andreas,

On Fri, 12 Jul 2024 07:35:59 +0200
Andreas Ziegler <br015@umbiko.net> wrote:

> Since commit 6b86f07 (package/fmt: bump to version 11.0.1), mpd fails to build:
> 
> /home/data/buildroot.x86_64/host/x86_64-buildroot-linux-uclibc/sysroot/usr/include/fmt/base.h:1392:29: error: passing ‘const fmt::v11::formatter<std::__exception_ptr::exception_ptr>’ as ‘this’ argument discards qualifiers [-fpermissive]
>  1392 |     ctx.advance_to(cf.format(*static_cast<qualified_type*>(arg), ctx));
>       |                    ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> In file included from ../src/Log.cxx:5:
> ../src/lib/fmt/ExceptionFormatter.hxx:15:14: note:   in call to ‘auto fmt::v11::formatter<std::__exception_ptr::exception_ptr>::format(std::__exception_ptr::exception_ptr, FormatContext&) [with FormatContext = fmt::v11::context]’
>    15 |         auto format(std::exception_ptr e, FormatContext &ctx) {
>       |              ^~~~~~
> 
> Adapt an upstream change to restore mpd compatibility with fmt 11.  
> 
> Fixes: 
> 	http://autobuild.buildroot.net/results/73514ea76a5960f59b4c50e2074571b10e4682d4
> 	http://autobuild.buildroot.net/results/a58ddbdfe35bd19021e65db0b8b8cc4c1c884d51
> 
> Signed-off-by: Andreas Ziegler <br015@umbiko.net>
> ---
>  ...fmt-support-build-with-libfmt-11.0.0.patch | 92 +++++++++++++++++++
>  1 file changed, 92 insertions(+)
>  create mode 100644 package/mpd/0002-lib-fmt-support-build-with-libfmt-11.0.0.patch

Thanks for the fix! Your patch had two small issues detected by "make
check-package":

WARNING: package/mpd/0002-lib-fmt-support-build-with-libfmt-11.0.0.patch:4: generate your patches with 'git format-patch -N'
WARNING: package/mpd/0002-lib-fmt-support-build-with-libfmt-11.0.0.patch:0: missing Upstream in the header (https://nightly.buildroot.org/#_additional_patch_documentation)

I fixed those two issues and applied. Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot