Re: [Buildroot] [PATCH v9 08/14] package/qt6/qt6languageserver: new package

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Roy,

On Tue, 25 Jun 2024 23:18:32 +0200
Roy Kollen Svendsen <roykollensvendsen@gmail.com> wrote:


> diff --git a/package/qt6/qt6languageserver/Config.in b/package/qt6/qt6languageserver/Config.in
> new file mode 100644
> index 0000000000..8a54ae1911
> --- /dev/null
> +++ b/package/qt6/qt6languageserver/Config.in
> @@ -0,0 +1,9 @@
> +config BR2_PACKAGE_QT6LANGUAGESERVER
> +	bool "qt6languageserver"
> +	help
> +	  Qt is a cross-platform application and UI framework for
> +	  developers using C++.
> +
> +	  This package corresponds to the qt6languageserver module.
> +
> +	  https://doc.qt.io/qt-6/qtlanguageserver-index.html

This link is a 404. I couldn't find a really good home page for this
particular module, so I used:

https://github.com/qt/qtlanguageserver


> +QT6LANGUAGESERVER_CMAKE_BACKEND = ninja
> +
> +QT6LANGUAGESERVER_LICENSE = \
> +	GPL-2.0+ or LGPL-3.0, \
> +	GPL-3.0, GFDL-1.3 no invariants (docs)

Same comment on the licensing terms, these are not correct I believe,
so I changed them to:

+QT6LANGUAGESERVER_LICENSE = \
+       GPL-2.0 or LGPL-3.0 or GPL-3.0, \
+       GPL-3.0 (tests)

when applying.

> +QT6LANGUAGESERVER_LICENSE_FILES = \
> +	LICENSES/GPL-2.0-only.txt \
> +	LICENSES/GPL-3.0-only.txt \
> +	LICENSES/LGPL-3.0-only.txt \
> +	LICENSES/GFDL-1.3-no-invariants-only.txt

I should have dropped this GFDL-1.3-no-invariants-only.txt though, as
there is no documentation under this license in this submodule. Maybe
something to fix as a follow-up patch.

Applied with the changes detailed above. Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot