Re: [RFC PATCH 2/8] arch/s390: Teach arch_get_unmapped_area{_topdown} to handle hugetlb mappings

[kernel test robot <lkp@intel.com>]

Hi Oscar,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on akpm-mm/mm-everything]
[also build test ERROR on s390/features powerpc/next powerpc/fixes deller-parisc/for-next linus/master v6.10-rc7 next-20240711]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Oscar-Salvador/mm-mmap-Teach-generic_get_unmapped_area-_topdown-to-handle-hugetlb-mappings/20240710-233828
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link:    https://lore.kernel.org/r/20240710105042.30165-3-osalvador%40suse.de
patch subject: [RFC PATCH 2/8] arch/s390: Teach arch_get_unmapped_area{_topdown} to handle hugetlb mappings
config: s390-allnoconfig (https://download.01.org/0day-ci/archive/20240712/202407121517.z2TFcGoE-lkp@intel.com/config)
compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project a0c6b8aef853eedaa0980f07c0a502a5a8a9740e)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240712/202407121517.z2TFcGoE-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202407121517.z2TFcGoE-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from arch/s390/mm/mmap.c:13:
   In file included from include/linux/mm.h:2221:
   include/linux/vmstat.h:514:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
     514 |         return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
         |                               ~~~~~~~~~~~ ^ ~~~
>> arch/s390/mm/mmap.c:76:14: error: call to undeclared function 'is_file_hugepages'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
      76 |         if (filp && is_file_hugepages(filp))
         |                     ^
>> arch/s390/mm/mmap.c:77:10: error: call to undeclared function 'huge_page_mask_align'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
      77 |                 return huge_page_mask_align(filp);
         |                        ^
   arch/s390/mm/mmap.c:111:16: error: call to undeclared function 'is_file_hugepages'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     111 |         if (!(file && is_file_hugepages(filp))
         |                       ^
>> arch/s390/mm/mmap.c:111:8: error: use of undeclared identifier 'file'; did you mean 'filp'?
     111 |         if (!(file && is_file_hugepages(filp))
         |               ^~~~
         |               filp
   arch/s390/mm/mmap.c:85:51: note: 'filp' declared here
      85 | unsigned long arch_get_unmapped_area(struct file *filp, unsigned long addr,
         |                                                   ^
>> arch/s390/mm/mmap.c:112:3: error: expected ')'
     112 |                 info.align_offset = pgoff << PAGE_SHIFT;
         |                 ^
   arch/s390/mm/mmap.c:111:5: note: to match this '('
     111 |         if (!(file && is_file_hugepages(filp))
         |            ^
   arch/s390/mm/mmap.c:150:16: error: call to undeclared function 'is_file_hugepages'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     150 |         if (!(file && is_file_hugepages(filp))
         |                       ^
   arch/s390/mm/mmap.c:150:8: error: use of undeclared identifier 'file'; did you mean 'filp'?
     150 |         if (!(file && is_file_hugepages(filp))
         |               ^~~~
         |               filp
   arch/s390/mm/mmap.c:121:59: note: 'filp' declared here
     121 | unsigned long arch_get_unmapped_area_topdown(struct file *filp, unsigned long addr,
         |                                                           ^
   arch/s390/mm/mmap.c:151:3: error: expected ')'
     151 |                 info.align_offset = pgoff << PAGE_SHIFT;
         |                 ^
   arch/s390/mm/mmap.c:150:5: note: to match this '('
     150 |         if (!(file && is_file_hugepages(filp))
         |            ^
   1 warning and 8 errors generated.


vim +/is_file_hugepages +76 arch/s390/mm/mmap.c

    73	
    74	static int get_align_mask(struct file *filp, unsigned long flags)
    75	{
  > 76		if (filp && is_file_hugepages(filp))
  > 77			return huge_page_mask_align(filp);
    78		if (!(current->flags & PF_RANDOMIZE))
    79			return 0;
    80		if (filp || (flags & MAP_SHARED))
    81			return MMAP_ALIGN_MASK << PAGE_SHIFT;
    82		return 0;
    83	}
    84	
    85	unsigned long arch_get_unmapped_area(struct file *filp, unsigned long addr,
    86					     unsigned long len, unsigned long pgoff,
    87					     unsigned long flags)
    88	{
    89		struct mm_struct *mm = current->mm;
    90		struct vm_area_struct *vma;
    91		struct vm_unmapped_area_info info = {};
    92	
    93		if (len > TASK_SIZE - mmap_min_addr)
    94			return -ENOMEM;
    95	
    96		if (flags & MAP_FIXED)
    97			goto check_asce_limit;
    98	
    99		if (addr) {
   100			addr = PAGE_ALIGN(addr);
   101			vma = find_vma(mm, addr);
   102			if (TASK_SIZE - len >= addr && addr >= mmap_min_addr &&
   103			    (!vma || addr + len <= vm_start_gap(vma)))
   104				goto check_asce_limit;
   105		}
   106	
   107		info.length = len;
   108		info.low_limit = mm->mmap_base;
   109		info.high_limit = TASK_SIZE;
   110		info.align_mask = get_align_mask(filp, flags);
 > 111		if (!(file && is_file_hugepages(filp))
 > 112			info.align_offset = pgoff << PAGE_SHIFT;
   113		addr = vm_unmapped_area(&info);
   114		if (offset_in_page(addr))
   115			return addr;
   116	
   117	check_asce_limit:
   118		return check_asce_limit(mm, addr, len);
   119	}
   120	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki