From: Rob Herring <robh@kernel.org>
To: Jack Yu <jack.yu@realtek.com>
Cc: "broonie@kernel.org" <broonie@kernel.org>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"lars@metafoo.de" <lars@metafoo.de>,
"Flove(HsinFu)" <flove@realtek.com>,
"Oder Chiou" <oder_chiou@realtek.com>,
"Shuming [范書銘]" <shumingf@realtek.com>,
"Derek [方德義]" <derek.fang@realtek.com>
Subject: Re: [PATCH v3] ASoC: rt1318: Add RT1318 audio amplifier driver
Date: Fri, 12 Jul 2024 12:18:41 -0600 [thread overview]
Message-ID: <20240712181841.GA1448997-robh@kernel.org> (raw)
In-Reply-To: <b3055442ce6d4994aa01aa1fad6ba1fe@realtek.com>
On Wed, Jun 19, 2024 at 05:53:42AM +0000, Jack Yu wrote:
> This is the initial i2s-based amplifier driver for rt1318.
>
> Signed-off-by: Jack Yu <jack.yu@realtek.com>
> ---
> include/sound/rt1318.h | 16 +
> sound/soc/codecs/Kconfig | 5 +
> sound/soc/codecs/Makefile | 2 +
> sound/soc/codecs/rt1318.c | 1354 +++++++++++++++++++++++++++++++++++++
> sound/soc/codecs/rt1318.h | 342 ++++++++++
> 5 files changed, 1719 insertions(+)
> create mode 100644 include/sound/rt1318.h
> create mode 100644 sound/soc/codecs/rt1318.c
> create mode 100644 sound/soc/codecs/rt1318.h
[...]
> +
> +static const struct of_device_id rt1318_of_match[] = {
> + { .compatible = "realtek,rt1318", },
This is not documented. Please add a DT binding schema for it.
Rob
prev parent reply other threads:[~2024-07-12 18:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 5:53 [PATCH v3] ASoC: rt1318: Add RT1318 audio amplifier driver Jack Yu
2024-06-20 11:13 ` Mark Brown
2024-07-12 18:18 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240712181841.GA1448997-robh@kernel.org \
--to=robh@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=derek.fang@realtek.com \
--cc=flove@realtek.com \
--cc=jack.yu@realtek.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
--cc=shumingf@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.