Re: [Buildroot] [PATCH 1/1] package/x265: fix armv6 cross compilation issue

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: David Barbion <davidb@230ruedubac.fr>
Cc: Bernd Kuhls <bernd.kuhls@t-online.de>,
	Thijs Vermeir <thijsvermeir@gmail.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/x265: fix armv6 cross compilation issue
Date: Sat, 13 Jul 2024 10:50:08 +0200	[thread overview]
Message-ID: <20240713105008.5ff2d290@windsurf> (raw)
In-Reply-To: <20221127081232.2160208-1-davidb@230ruedubac.fr>

Hello David,

On Sun, 27 Nov 2022 09:12:32 +0100
David Barbion <davidb@230ruedubac.fr> wrote:

> When running a program that depends on x265, it crashes with the
> message: illegal instruction
> 
> The package x265 was forcibly compiled with the gcc flag -mfpu=neon even
> if the target CPU does not support the neon instruction set.
> This fix adds the cmake flag CROSS_COMPILE_ARM to correctly set gcc flags
> when compiling for ARMv6 architecture.
> 
> Signed-off-by: David Barbion <davidb@230ruedubac.fr>
> ---
>  package/x265/x265.mk | 4 ++++
>  1 file changed, 4 insertions(+)

Sorry for the very, very long delay with which we are getting back to
you, and thanks for your investigation. Your patch was indeed fixing
the problem, but I took a step back and fixed a little more. See the
following two patches:

  https://gitlab.com/buildroot.org/buildroot/-/commit/9d62687d0024f7e3bac68157f1250970ef45abff
  https://gitlab.com/buildroot.org/buildroot/-/commit/1fbd26f83169a206bdf9c36c85510a33c0e7a864

Of course, if you're still working on your project, it would be great
to get a confirmation that those patches are still fixing the problem
for you.

Once again, thanks for your contribution!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot