From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: "Stefan Sørensen" <stefan.sorensen@spectralink.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2, 1/1] package/cracklib: python needs autoreconf
Date: Sat, 13 Jul 2024 15:02:20 +0200 [thread overview]
Message-ID: <20240713150220.214cb40c@windsurf> (raw)
In-Reply-To: <20240212175251.721803-1-fontaine.fabrice@gmail.com>
On Mon, 12 Feb 2024 18:52:51 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Set CRACKLIB_AUTORECONF when building python to regenerate py-compile
> and avoid the following build failure with python 3.12 (which removed
> imp module) raised since commit
> 36e635d2d5c0166476858aa239ccbe78e8f2af14:
>
> Traceback (most recent call last):
> File "<string>", line 2, in <module>
> ModuleNotFoundError: No module named 'imp'
> make[3]: *** [Makefile:485: install-pythonPYTHON] Error 1
>
> Indeed, after autoreconf, py-compile will contain:
>
> if test "$python_major" -le 2; then
> import_lib=imp
> import_test="hasattr(imp, 'get_tag')"
> import_call=imp.cache_from_source
> import_arg2=', False' # needed in one call and not the other
> else
> import_lib=importlib
> import_test="hasattr(sys.implementation, 'cache_tag')"
> import_call=importlib.util.cache_from_source
> import_arg2=
> fi
>
> $PYTHON -c "
> import sys, os, py_compile, $import_lib
>
> instead of:
>
> import sys, os, py_compile, imp
>
> Fixes: 36e635d2d5c0166476858aa239ccbe78e8f2af14
> - http://autobuild.buildroot.org/results/aec4c19fdf8087c76c1d5f472e855e0f84fcf7fd
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> Changes v1 -> v2 (after review of Thomas Petazzoni):
> - Give more details in commit message
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-07-13 13:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-12 17:52 [Buildroot] [PATCH v2, 1/1] package/cracklib: python needs autoreconf Fabrice Fontaine
2024-07-13 13:02 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240713150220.214cb40c@windsurf \
--to=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=stefan.sorensen@spectralink.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.