From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: [groeck-staging:hwmon-staging 111/143] drivers/hwmon/lm95234.c:223 lm95234_temp_read() error: uninitialized symbol 'ret'.
Date: Sat, 13 Jul 2024 19:36:00 +0800 [thread overview]
Message-ID: <202407131905.rNPAD1Ac-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-hwmon@vger.kernel.org
TO: Guenter Roeck <linux@roeck-us.net>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-staging
head: 80e45111b670e9c913398f5ad54196a99a739497
commit: 85a6f963ad7f3657dff782c3e3ac40ab6c95f62c [111/143] hwmon: (lm9534) Convert to with_info hwmon API
:::::: branch date: 2 days ago
:::::: commit date: 2 days ago
config: i386-randconfig-141-20240713 (https://download.01.org/0day-ci/archive/20240713/202407131905.rNPAD1Ac-lkp@intel.com/config)
compiler: gcc-12 (Ubuntu 12.3.0-9ubuntu2) 12.3.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202407131905.rNPAD1Ac-lkp@intel.com/
New smatch warnings:
drivers/hwmon/lm95234.c:223 lm95234_temp_read() error: uninitialized symbol 'ret'.
Old smatch warnings:
drivers/hwmon/lm95234.c:231 lm95234_temp_read() error: uninitialized symbol 'ret'.
vim +/ret +223 drivers/hwmon/lm95234.c
e1eb49063b301f Guenter Roeck 2013-03-10 177
85a6f963ad7f36 Guenter Roeck 2024-07-10 178 static int lm95234_temp_read(struct device *dev, u32 attr, int channel, long *val)
e1eb49063b301f Guenter Roeck 2013-03-10 179 {
9d86bd6ba3ba2f Guenter Roeck 2013-09-04 180 struct lm95234_data *data = dev_get_drvdata(dev);
85a6f963ad7f36 Guenter Roeck 2024-07-10 181 struct regmap *regmap = data->regmap;
85a6f963ad7f36 Guenter Roeck 2024-07-10 182 u32 regval, mask;
efae967d04e36c Guenter Roeck 2024-07-07 183 int ret;
e1eb49063b301f Guenter Roeck 2013-03-10 184
85a6f963ad7f36 Guenter Roeck 2024-07-10 185 switch (attr) {
85a6f963ad7f36 Guenter Roeck 2024-07-10 186 case hwmon_temp_input:
85a6f963ad7f36 Guenter Roeck 2024-07-10 187 return lm95234_read_temp(regmap, channel, val);
85a6f963ad7f36 Guenter Roeck 2024-07-10 188 case hwmon_temp_max_alarm:
85a6f963ad7f36 Guenter Roeck 2024-07-10 189 ret = regmap_read(regmap, lm95234_alarm_reg(channel), ®val);
85a6f963ad7f36 Guenter Roeck 2024-07-10 190 if (ret)
e1eb49063b301f Guenter Roeck 2013-03-10 191 return ret;
85a6f963ad7f36 Guenter Roeck 2024-07-10 192 *val = !!(regval & BIT(channel));
85a6f963ad7f36 Guenter Roeck 2024-07-10 193 break;
85a6f963ad7f36 Guenter Roeck 2024-07-10 194 case hwmon_temp_crit_alarm:
85a6f963ad7f36 Guenter Roeck 2024-07-10 195 ret = regmap_read(regmap, LM95234_REG_STS_TCRIT1, ®val);
efae967d04e36c Guenter Roeck 2024-07-07 196 if (ret)
efae967d04e36c Guenter Roeck 2024-07-07 197 return ret;
85a6f963ad7f36 Guenter Roeck 2024-07-10 198 *val = !!(regval & BIT(channel));
85a6f963ad7f36 Guenter Roeck 2024-07-10 199 break;
85a6f963ad7f36 Guenter Roeck 2024-07-10 200 case hwmon_temp_crit_hyst:
85a6f963ad7f36 Guenter Roeck 2024-07-10 201 return lm95234_hyst_get(data, LM95234_REG_TCRIT1(channel), val);
85a6f963ad7f36 Guenter Roeck 2024-07-10 202 case hwmon_temp_type:
85a6f963ad7f36 Guenter Roeck 2024-07-10 203 ret = regmap_read(regmap, LM95234_REG_REM_MODEL, ®val);
efae967d04e36c Guenter Roeck 2024-07-07 204 if (ret)
85a6f963ad7f36 Guenter Roeck 2024-07-10 205 return ret;
85a6f963ad7f36 Guenter Roeck 2024-07-10 206 *val = (regval & BIT(channel)) ? 1 : 2;
85a6f963ad7f36 Guenter Roeck 2024-07-10 207 break;
85a6f963ad7f36 Guenter Roeck 2024-07-10 208 case hwmon_temp_offset:
85a6f963ad7f36 Guenter Roeck 2024-07-10 209 ret = regmap_read(regmap, LM95234_REG_OFFSET(channel - 1), ®val);
efae967d04e36c Guenter Roeck 2024-07-07 210 if (ret)
efae967d04e36c Guenter Roeck 2024-07-07 211 return ret;
85a6f963ad7f36 Guenter Roeck 2024-07-10 212 *val = sign_extend32(regval, 7) * 500;
85a6f963ad7f36 Guenter Roeck 2024-07-10 213 break;
85a6f963ad7f36 Guenter Roeck 2024-07-10 214 case hwmon_temp_fault:
85a6f963ad7f36 Guenter Roeck 2024-07-10 215 ret = regmap_read(regmap, LM95234_REG_STS_FAULT, ®val);
efae967d04e36c Guenter Roeck 2024-07-07 216 if (ret)
efae967d04e36c Guenter Roeck 2024-07-07 217 return ret;
85a6f963ad7f36 Guenter Roeck 2024-07-10 218 mask = (BIT(0) | BIT(1)) << ((channel - 1) << 1);
85a6f963ad7f36 Guenter Roeck 2024-07-10 219 *val = !!(regval & mask);
85a6f963ad7f36 Guenter Roeck 2024-07-10 220 break;
85a6f963ad7f36 Guenter Roeck 2024-07-10 221 case hwmon_temp_max:
85a6f963ad7f36 Guenter Roeck 2024-07-10 222 regmap_read(regmap, lm95234_crit_reg(channel), ®val);
85a6f963ad7f36 Guenter Roeck 2024-07-10 @223 if (ret)
e1eb49063b301f Guenter Roeck 2013-03-10 224 return ret;
85a6f963ad7f36 Guenter Roeck 2024-07-10 225 *val = regval * 1000;
85a6f963ad7f36 Guenter Roeck 2024-07-10 226 break;
85a6f963ad7f36 Guenter Roeck 2024-07-10 227 case hwmon_temp_max_hyst:
85a6f963ad7f36 Guenter Roeck 2024-07-10 228 return lm95234_hyst_get(data, lm95234_crit_reg(channel), val);
85a6f963ad7f36 Guenter Roeck 2024-07-10 229 case hwmon_temp_crit:
85a6f963ad7f36 Guenter Roeck 2024-07-10 230 regmap_read(regmap, LM95234_REG_TCRIT1(channel), ®val);
efae967d04e36c Guenter Roeck 2024-07-07 231 if (ret)
efae967d04e36c Guenter Roeck 2024-07-07 232 return ret;
85a6f963ad7f36 Guenter Roeck 2024-07-10 233 *val = regval * 1000;
85a6f963ad7f36 Guenter Roeck 2024-07-10 234 break;
85a6f963ad7f36 Guenter Roeck 2024-07-10 235 default:
85a6f963ad7f36 Guenter Roeck 2024-07-10 236 return -EOPNOTSUPP;
e1eb49063b301f Guenter Roeck 2013-03-10 237 }
85a6f963ad7f36 Guenter Roeck 2024-07-10 238 return 0;
e1eb49063b301f Guenter Roeck 2013-03-10 239 }
e1eb49063b301f Guenter Roeck 2013-03-10 240
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2024-07-13 11:39 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202407131905.rNPAD1Ac-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.