From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 18EE7C3DA49 for ; Sun, 14 Jul 2024 14:23:43 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id B67166062D; Sun, 14 Jul 2024 14:23:43 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id WHtCwEUAR46R; Sun, 14 Jul 2024 14:23:43 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 31DBE600B6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1720967023; bh=xMdq4r6pDe29U3iQgsGEdHf6i0KXDDWbX9J20uZTW1I=; h=Date:From:To:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=l+Ow+n98qhSVhoK2AM3e0J95sb6HyhBlaqyX8+gFJ4iIAfsebY3wltef3Gl9AB6yV u/zastnobdO+nfa3TGA/80QwNOz56a+rYwhQwtyj7LFCOb8RlQvr6RBqxHCYdExE/Q PezHiNA1NXNKxHrC599bGmUNFDuNiJqO7DkbqGaewGRtW9VHrQaSCL1tbKVkJSRJHi hYu5eWSIZa0pEvyMNwsziSzIiUjaZYQyHcCwOVIeayEp3wYUlSrb78G/7kgiCuiF11 KERYAWp7xNZfvh+Nr/cEbwFB6MnKLVEs9yhsF8gJ16T4rl02gT0yMsSVpQYLu0+RcL e8lR+uAU6fl+A== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id 31DBE600B6; Sun, 14 Jul 2024 14:23:43 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 75C5C1BF3D5 for ; Sun, 14 Jul 2024 14:23:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 627B460621 for ; Sun, 14 Jul 2024 14:23:41 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id WrBFGcnQWpF7 for ; Sun, 14 Jul 2024 14:23:40 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2604:1380:40e1:4800::1; helo=sin.source.kernel.org; envelope-from=kuba@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org 90D3560610 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 90D3560610 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by smtp3.osuosl.org (Postfix) with ESMTPS id 90D3560610 for ; Sun, 14 Jul 2024 14:23:40 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 5176ECE04F0; Sun, 14 Jul 2024 14:23:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0DA85C116B1; Sun, 14 Jul 2024 14:23:34 +0000 (UTC) Date: Sun, 14 Jul 2024 07:23:33 -0700 From: Jakub Kicinski To: Mateusz Polchlopek Message-ID: <20240714072333.2fff045c@kernel.org> In-Reply-To: <20240712093251.18683-4-mateusz.polchlopek@intel.com> References: <20240712093251.18683-1-mateusz.polchlopek@intel.com> <20240712093251.18683-4-mateusz.polchlopek@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1720967014; bh=UHj/nSLZ+PQOVweVrGhu6rnTn6njZLQzzk92qwM/x2k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Ass0/dJtFHwm57kcENeTqdaVj368yIZDCvYYWzlYEh5svG1OAEGOyO32cqBuOY8G3 fHgVwtYghIFMvkM+cssnN+KaWX1GS5Vu2piX6u6dt1OK9aaN213vUvp9NhGZx3pmAe NlC4Gh5OcBZ+ZRhqzOxmjBn4rNBKc23KlUiyVC50qEpCP3MiVmWsCF8/w/LAOoCMkN WLtGW0udmCnPElz12GeHAgu+lFWxo9WG6Rk7RxSggHBtOprF5lNvvi/jp3cjiBpJ8x 8RtkuXGakTIa9juStZFmlCgQu7zFnl0t6w+Yw7bBWJtDvFLHnreTTXD+TYag4iIhH6 Ai4q4t6sRuQ7g== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=none dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=Ass0/dJt Subject: Re: [Intel-wired-lan] [PATCH iwl-next v2 3/6] ice: add Tx hang devlink health reporter X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: willemb@google.com, Wojciech Drewek , dwaipayanray1@gmail.com, linux-kernel@vger.kernel.org, Igor Bagnucki , joe@perches.com, edumazet@google.com, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, apw@canonical.com, lukas.bulwahn@gmail.com, akpm@linux-foundation.org, Przemek Kitszel Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Fri, 12 Jul 2024 05:32:48 -0400 Mateusz Polchlopek wrote: > + err = devlink_health_report(reporter, msg, priv_ctx); > + if (err) { > + struct ice_pf *pf = devlink_health_reporter_priv(reporter); > + > + dev_err(ice_pf_to_dev(pf), > + "failed to report %s via devlink health, err %d\n", > + msg, err); My knee-jerk reaction is - why not put it in devlink_health_report()? Also, I'd rate limit the message. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C6AE63C8; Sun, 14 Jul 2024 14:23:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720967015; cv=none; b=tYfMkPt/RBiEavFGl7j6XWmec43mLePxT9J7j8krdyLWQyCVyurnvUnTIPWstlSbrh11eRDyQrVfxv4k8jV5VAa/GfvxHX81VycQU/qiyU+fac1/xcoRFS7+I8Qs2e0p8IhrEtERq6BGGos7iPo1Ql1x8ShadsKe1OuKnByeYJE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720967015; c=relaxed/simple; bh=UHj/nSLZ+PQOVweVrGhu6rnTn6njZLQzzk92qwM/x2k=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ftL3XG1F6AcJsRKzmG1CtMFEgYB5jZrbSzSwqBf4Te/OXyQ0wzJ1vuFKGw8PUJkJ+HV0So/4Hrd4P4GitAvMThqZPdkQ835tIaWgDqfNUHRpkL9mB6IfGRJ058zXdVAwse/Zqw+PLpZILPuC4E6nGft9WZXiRtWQ0H6JkJf0aus= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Ass0/dJt; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Ass0/dJt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0DA85C116B1; Sun, 14 Jul 2024 14:23:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1720967014; bh=UHj/nSLZ+PQOVweVrGhu6rnTn6njZLQzzk92qwM/x2k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Ass0/dJtFHwm57kcENeTqdaVj368yIZDCvYYWzlYEh5svG1OAEGOyO32cqBuOY8G3 fHgVwtYghIFMvkM+cssnN+KaWX1GS5Vu2piX6u6dt1OK9aaN213vUvp9NhGZx3pmAe NlC4Gh5OcBZ+ZRhqzOxmjBn4rNBKc23KlUiyVC50qEpCP3MiVmWsCF8/w/LAOoCMkN WLtGW0udmCnPElz12GeHAgu+lFWxo9WG6Rk7RxSggHBtOprF5lNvvi/jp3cjiBpJ8x 8RtkuXGakTIa9juStZFmlCgQu7zFnl0t6w+Yw7bBWJtDvFLHnreTTXD+TYag4iIhH6 Ai4q4t6sRuQ7g== Date: Sun, 14 Jul 2024 07:23:33 -0700 From: Jakub Kicinski To: Mateusz Polchlopek Cc: intel-wired-lan@lists.osuosl.org, apw@canonical.com, joe@perches.com, dwaipayanray1@gmail.com, lukas.bulwahn@gmail.com, akpm@linux-foundation.org, willemb@google.com, edumazet@google.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Przemek Kitszel , Igor Bagnucki , Wojciech Drewek Subject: Re: [Intel-wired-lan] [PATCH iwl-next v2 3/6] ice: add Tx hang devlink health reporter Message-ID: <20240714072333.2fff045c@kernel.org> In-Reply-To: <20240712093251.18683-4-mateusz.polchlopek@intel.com> References: <20240712093251.18683-1-mateusz.polchlopek@intel.com> <20240712093251.18683-4-mateusz.polchlopek@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 12 Jul 2024 05:32:48 -0400 Mateusz Polchlopek wrote: > + err = devlink_health_report(reporter, msg, priv_ctx); > + if (err) { > + struct ice_pf *pf = devlink_health_reporter_priv(reporter); > + > + dev_err(ice_pf_to_dev(pf), > + "failed to report %s via devlink health, err %d\n", > + msg, err); My knee-jerk reaction is - why not put it in devlink_health_report()? Also, I'd rate limit the message.