Re: [Buildroot] [PATCH 1/1] package/btrfs-progs: bump version to 6.9.2

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Julien Olivain <ju.o@free.fr>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/btrfs-progs: bump version to 6.9.2
Date: Sun, 14 Jul 2024 15:16:52 +0200	[thread overview]
Message-ID: <20240714151652.7a9b94af@windsurf> (raw)
In-Reply-To: <20240714124910.1928300-1-ju.o@free.fr>

Hello,

Thanks for the patch!

On Sun, 14 Jul 2024 14:49:10 +0200
Julien Olivain <ju.o@free.fr> wrote:

> +# btrfs-progs uses the glibc register_printf_specifier() and
> +# register_printf_modifier() functions, if the header <printf.h> is
> +# detected at configure time. uClibc has this header, but does not
> +# provide those functions. This leads to build failure. In case no
> +# header is present, btrfs-progs is providing a workaround. We disable
> +# the <printf.h> header detection for uClibc toolchains. Musl libc is
> +# not impacted, because it does not provide a <printf.h> header.
> +ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC),y)
> +BTRFS_PROGS_CONF_ENV += ac_cv_header_printf_h=no
> +endif

Then what about improving the configure.ac detection logic to not check
for printf.h but rather the availability of register_printf_specifier()
and register_printf_modifier() ? This would be the right thing to do in
this situation.

Do you think you could have a look into this?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot