From: "Jun Wang" <junwang01@cestc.cn>
To: stephen <stephen@networkplumber.org>
Cc: dev <dev@dpdk.org>
Subject: Re: [PATCH v1] net/e1000: do not update link status in secondary process
Date: Sun, 14 Jul 2024 16:26:26 +0800 [thread overview]
Message-ID: <202407141626262115324@cestc.cn> (raw)
In-Reply-To: 20240712101704.20e3f8a3@hermes.local
[-- Attachment #1: Type: text/plain, Size: 695 bytes --]
>> The code to update link status is not safe in secondary process.
>> If called from secondary it will crash, example from dumpcap:
>> eth_em_link_update
>>
>> Signed-off-by: Jun Wang <junwang01@cestc.cn>
>
> Wouldn't it be better to fix the code in e1000_check_link to work in
> secondary process. There are network virtual appliances that use
> secondary process for all processing.
Yes, the e1000 virtual network card currently does not work properly
in the secondary process. After skipping eth_em_link_update, I tested
the e1000 card and it was able to capture packets normally. For the
secondary process, I think eth_em_link_update is not necessary.
Jun Wang
[-- Attachment #2: Type: text/html, Size: 1853 bytes --]
next prev parent reply other threads:[~2024-07-14 8:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-12 11:30 [PATCH v1] net/e1000: do not update link status in secondary process Jun Wang
2024-07-12 17:17 ` Stephen Hemminger
2024-07-14 8:26 ` Jun Wang [this message]
2024-07-22 17:08 ` Bruce Richardson
2024-07-23 2:07 ` Jun Wang
2024-08-22 15:58 ` Bruce Richardson
2024-08-22 16:02 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202407141626262115324@cestc.cn \
--to=junwang01@cestc.cn \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.