All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: iommu@lists.linux.dev, Kevin Tian <kevin.tian@intel.com>
Cc: patches@lists.linux.dev
Subject: Re: [PATCH] iommufd: Put constants for all the uAPI enums
Date: Mon, 15 Jul 2024 09:45:44 -0300	[thread overview]
Message-ID: <20240715124544.GA622030@nvidia.com> (raw)
In-Reply-To: <0-v1-2c06ec044924+133-iommufd_uapi_const_jgg@nvidia.com>

On Thu, Jul 11, 2024 at 09:11:03PM -0300, Jason Gunthorpe wrote:
> Relying on position in the enum makes it subtly harder when doing merge
> resolutions or backporting as it is easy to grab a patch and not notice it
> is a uAPI change with a differently ordered enum. This may become a bigger
> problem in next cycles when iommu_hwpt_invalidate_data_type and other
> per-driver enums have patches flowing through different trees.
> 
> So lets start including constants for all the uAPI enums to make this
> safer.
> 
> No functional change.
> 
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> ---
>  include/uapi/linux/iommufd.h | 40 ++++++++++++++++++------------------
>  1 file changed, 20 insertions(+), 20 deletions(-)

Applied

Jason

      parent reply	other threads:[~2024-07-15 12:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-12  0:11 [PATCH] iommufd: Put constants for all the uAPI enums Jason Gunthorpe
2024-07-15  2:25 ` Tian, Kevin
2024-07-15 10:14 ` Yi Liu
2024-07-15 12:45 ` Jason Gunthorpe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240715124544.GA622030@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=iommu@lists.linux.dev \
    --cc=kevin.tian@intel.com \
    --cc=patches@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.