From: Peter Zijlstra <peterz@infradead.org>
To: Kyle Huey <me@kylehuey.com>
Cc: Jiri Olsa <olsajiri@gmail.com>,
khuey@kylehuey.com, Ingo Molnar <mingo@redhat.com>,
Namhyung Kim <namhyung@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
robert@ocallahan.org, Joe Damato <jdamato@fastly.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
"Liang, Kan" <kan.liang@linux.intel.com>,
Andrii Nakryiko <andrii@kernel.org>, Song Liu <song@kernel.org>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
bpf@vger.kernel.org
Subject: Re: [PATCH] perf/bpf: Don't call bpf_overflow_handler() for tracing events
Date: Mon, 15 Jul 2024 18:30:03 +0200 [thread overview]
Message-ID: <20240715163003.GK14400@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <CAP045Aq3Mv2oDMCU8-Afe7Ne+RLH62120F3RWqc+p9STpcxyxg@mail.gmail.com>
On Mon, Jul 15, 2024 at 08:19:44AM -0700, Kyle Huey wrote:
> I think this would probably work but stealing the bit seems far more
> complicated than just gating on perf_event_is_tracing().
perf_event_is_tracing() is something like 3 branches. It is not a simple
conditional. Combined with that re-load and the wrong return value, this
all wants a cleanup.
Using that LSB works, it's just that the code aint pretty.
next prev parent reply other threads:[~2024-07-15 16:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-13 4:46 [PATCH] perf/bpf: Don't call bpf_overflow_handler() for tracing events Kyle Huey
2024-07-13 20:32 ` Jiri Olsa
2024-07-15 11:12 ` Peter Zijlstra
2024-07-15 14:33 ` Kyle Huey
2024-07-15 15:04 ` Peter Zijlstra
2024-07-15 15:19 ` Kyle Huey
2024-07-15 16:30 ` Peter Zijlstra [this message]
2024-07-15 16:48 ` Kyle Huey
2024-07-16 7:25 ` Jiri Olsa
2024-07-19 18:26 ` Andrii Nakryiko
2024-07-26 12:37 ` Kyle Huey
2024-07-26 16:34 ` Andrii Nakryiko
2024-07-26 16:35 ` Kyle Huey
2024-08-05 11:55 ` Joe Damato
2024-08-13 10:37 ` Joe Damato
2024-08-13 13:38 ` Kyle Huey
2024-07-20 16:03 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240715163003.GK14400@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=irogers@google.com \
--cc=jdamato@fastly.com \
--cc=kan.liang@linux.intel.com \
--cc=khuey@kylehuey.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=me@kylehuey.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=olsajiri@gmail.com \
--cc=robert@ocallahan.org \
--cc=song@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.