From: Stefano Brivio <sbrivio@redhat.com>
To: Florian Westphal <fw@strlen.de>
Cc: <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH nf] selftests: netfilter: add test case for recent mismatch bug
Date: Mon, 15 Jul 2024 16:31:05 +0200 [thread overview]
Message-ID: <20240715163105.2571a92a@elisabeth> (raw)
In-Reply-To: <20240715115532.2758-1-fw@strlen.de>
On Mon, 15 Jul 2024 13:55:29 +0200
Florian Westphal <fw@strlen.de> wrote:
> Without 'netfilter: nf_set_pipapo: fix initial map fill' this fails:
>
> TEST: reported issues
> Add two elements, flush, re-add 1s [ OK ]
> net,mac with reload 1s [ OK ]
> net,port,proto 1s [FAIL]
> post-add: should have returned 10.5.8.0/24 . 51-60 . 6-17 but got table inet filter {
> set test {
> type ipv4_addr . inet_service . inet_proto
> flags interval,timeout
> elements = { 10.5.7.0/24 . 51-60 . 6-17 }
> }
> }
>
> The other sets defined in the selftest do not trigger this bug, it only
> occurs if the first field group bitsize is smaller than the largest
> group bitsize.
>
> For each added element, check 'get' works and actually returns the
> requested range.
> After map has been filled, check all added ranges can still be
> retrieved.
>
> For each deleted element, check that 'get' fails.
>
> Based on a reproducer script from Yi Chen.
>
> Signed-off-by: Florian Westphal <fw@strlen.de>
Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
--
Stefano
prev parent reply other threads:[~2024-07-15 14:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-15 11:55 [PATCH nf] selftests: netfilter: add test case for recent mismatch bug Florian Westphal
2024-07-15 14:31 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240715163105.2571a92a@elisabeth \
--to=sbrivio@redhat.com \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.