From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/tar: fix linking with libiconv
Date: Mon, 15 Jul 2024 16:39:33 +0200 [thread overview]
Message-ID: <20240715163933.7317e08c@windsurf> (raw)
In-Reply-To: <20240715102848.7dc3d619@windsurf>
Hello,
On Mon, 15 Jul 2024 10:28:48 +0200
Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
> I've changed this to:
>
> Fixes:
>
> https://gitlab.com/buildroot.org/buildroot/-/issues/4
> http://autobuild.buildroot.net/results/c074c2e22a7f764400ecc7dd1a6cd6022fa87fb9/
>
> I don't know if Peter will agree, but I find the full URL to the gitlab
> issue to be clearer. One can directly click, we can more easily grep
> through the git commit messages to find all commits that fix a Gitlab
> issue, etc.
Except these patches are touching Makefile.am, so we need
TAR_AUTORECONF = YES.
... except TAR_AUTORECONF = YES is fine for target tar, but not
host-tar, because it would add a dependency on
host-{autoconf,automake,libtool}, which themselves depend on host-tar.
This caused some failures in the autobuilders:
http://autobuild.buildroot.net/results/efd/efdf7cf9ede810ed7f766cc4138b16054bc0c18a/build-end.log
So I added a quirk:
https://gitlab.com/buildroot.org/buildroot/-/commit/69cbb563a124002fcb3e2725c3516b502587f9cc
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-07-15 14:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-30 21:09 [Buildroot] [PATCH] package/tar: fix linking with libiconv Yann E. MORIN
2024-07-15 8:28 ` Thomas Petazzoni via buildroot
2024-07-15 14:39 ` Thomas Petazzoni via buildroot [this message]
2024-08-20 19:57 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240715163933.7317e08c@windsurf \
--to=buildroot@buildroot.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.