Re: Proposal: Enhancing Commit Tagging for Stable Kernel Branches

[Mauro Carvalho Chehab <maurochehab@gmail.com>]

Em Mon, 15 Jul 2024 15:24:42 -0400
James Bottomley <James.Bottomley@HansenPartnership.com> escreveu:

> On Mon, 2024-07-15 at 14:06 -0500, Dan Carpenter wrote:
> [...]
> > The one question I have is for patches which pre-date git.  I was
> > told to leave the Fixes tag off in that case, but I think that's out
> > of date. It's more useful to say "Fixes: 1da177e4c3f4 ("Linux-2.6.12-
> > rc2")".  
> 
> Actually, we have a history tree (based on Bitkeeper) that goes back
> before that:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git/
> 
> So I'd tag these as
> 
> Fixes: 3bc0a5f5c1 (history "ext3: reservation info cleanup")

The problem with such tags is that eventually conflicts may arise
with other checksum. Also, people may not notice that the fixes are
referring to a different tree.

IMO, if you want to reference older commits, the best would be to use
Link instead:

Link: https://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git/commit/?id=3bc0a5f5c1

and perhaps keep:

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")

Regards,
Mauro