From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f50.google.com (mail-io1-f50.google.com [209.85.166.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1245A1BF3A for ; Wed, 17 Jul 2024 13:15:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721222143; cv=none; b=B2UZ+TSrjXkIgFWKESGh9WQ3Zvu5mV+orA/HN1ZqpI0SODHCmAVgh1QNEoTmCzuQ4GvvOe5QIA6qRVJhqE+KQMyD6ERb3kVienDRi49gnZipEw4gm46qviW5RiGnye5e+Zk54xRa9Dc6iU0ZxJehSKTR4Lkwbu0IGwc61X0itp8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721222143; c=relaxed/simple; bh=w3lM3QxgiIO2XloHLHUAuPqr2I7Bak5yf/pxxvSHH54=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=p8GUwK2fLWPgFnIC1KBJuu1/Jp0HIggt2HGk/nX1Yap2pnVuJcvcDQEK9W2R5LauFZ7BqBbuFn7eUC0PwgCiT0UQDFaz4Tvl3FOCxeaQUbt6TLTIio3JmcidBTUyvZUWnn8VsQbPwsvPqlHspoPpU2ad2jQBOwVurDaOuYBMDqQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com; spf=pass smtp.mailfrom=ventanamicro.com; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b=pCn679AA; arc=none smtp.client-ip=209.85.166.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b="pCn679AA" Received: by mail-io1-f50.google.com with SMTP id ca18e2360f4ac-7f70a708f54so50416739f.3 for ; Wed, 17 Jul 2024 06:15:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1721222141; x=1721826941; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=nfyN59SqKKWvXLU3CmJIUvS3Qc0ugEMt32zK3kDXEnU=; b=pCn679AAqbmQ8aEZ0gMkxczOAnX6RI3DGskk2a67QuSwJJmQ/LVcSQDD4BQ+7G758U Zazq2hfQl/h0iYjfJOutzc9mHP9KeXIGb0X3+XCkoDkZd1yBDghfwBBwtVPjhENR0RQY c/I3z29/8ElRq6es6qhON0x/X6AKbPeqMvItG2ModEdzAhnX65nom1gGKvjsH4fqJeC8 lfayo+Xbxm4+cfVxIpqxpB1XsgPnprQGPRASbCAm7dlFuWLr9CcSAoShnJAorkFRtg04 aXcOMQfex2KWDt+Ru2+tgeNYg/YMTVb0r+h/BZjWr/p2/53jYW1OqByr/h1tWXkz+glU jqDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721222141; x=1721826941; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nfyN59SqKKWvXLU3CmJIUvS3Qc0ugEMt32zK3kDXEnU=; b=quvyG0CHDvet6XitatUQZbrMJ9+mUPnJdHA2mbu6lu+rbnMv5FiauubIaYriKbNCkm ZKvPz8/mmRPndrx1oqTCBs+3PyBVDaL3hJ7w2mpLp908aAWE8iUhEQP2c6cXCiNsYMZN BBDck/j1amcWF2OOQb87DbtElYj9opc+XpFka0iD6VYgO4Yb1Hw3NFsaqjXmF5OIdR6h XXIWz3vdfKcH0IXwhZZ2Rnz3K8qcaiD3bBIi7ItqhBnKOs2HSYxJkIduCJ4W1iwfmrPJ 7pI8Ypmq53aKd4un5xU4GS06LYYwxaTRCk8n5yzQ8GDyZsfieG/isz1LVF9/CclNWQek nhaw== X-Forwarded-Encrypted: i=1; AJvYcCXoIaPTAevpCIAAYELf18VChpiI9B5/mOF+X2bAKAF2WBFilGoLhBspLpV1fmXn/uteTQYg9LrGgoPZW4l2s1TiXn8a X-Gm-Message-State: AOJu0YxVdP9dzj8eJhwzoGpKgSgIZvWXv2omTxLxH9pfbtb4D0rQQVlI ERHb5Xt/hWbs4wUUJmvXCQTv2Y9QKn1PhtJzGiFUzzAbmdtAeQSSj85MRLul0kY= X-Google-Smtp-Source: AGHT+IGqABt+N2by4fsdmIqsdoYWgZufcwOnrxKz5lnVlQ+PsNG/iBjeIJbo82SPl4wG/8emOYWz6A== X-Received: by 2002:a05:6602:1406:b0:7f9:1b3b:8465 with SMTP id ca18e2360f4ac-817109e76cbmr216963839f.11.1721222141068; Wed, 17 Jul 2024 06:15:41 -0700 (PDT) Received: from localhost ([140.82.166.162]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4c210f21be4sm658490173.91.2024.07.17.06.15.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jul 2024 06:15:40 -0700 (PDT) Date: Wed, 17 Jul 2024 08:15:40 -0500 From: Andrew Jones To: Alexandre Ghiti Cc: Paul Walmsley , Palmer Dabbelt , Albert Ou , Samuel Holland , Peter Zijlstra , Josh Poimboeuf , Jason Baron , Steven Rostedt , Ard Biesheuvel , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= , Pu Lehui , Puranjay Mohan , Luke Nelson , Xi Wang , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, Geert Uytterhoeven Subject: Re: [PATCH] riscv: patch: Remove redundant functions Message-ID: <20240717-515ffec38da9b1f5df03e42c@orel> References: <20240717084102.150914-1-alexghiti@rivosinc.com> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240717084102.150914-1-alexghiti@rivosinc.com> On Wed, Jul 17, 2024 at 10:41:02AM GMT, Alexandre Ghiti wrote: > Commit edf2d546bfd6f5c4 ("riscv: patch: Flush the icache right after > patching to avoid illegal insns") removed the last differences between > patch_text_set_nosync() and patch_insn_set(), and between > patch_text_nosync() and patch_insn_write(). > > So remove the redundant *_nosync() functions. > > Reported-by: Geert Uytterhoeven > Closes: https://lore.kernel.org/linux-riscv/CAMuHMdUwx=rU2MWhFTE6KhYHm64phxx2Y6u05-aBLGfeG5696A@mail.gmail.com/ > Signed-off-by: Alexandre Ghiti > --- > arch/riscv/errata/sifive/errata.c | 4 ++-- > arch/riscv/errata/thead/errata.c | 2 +- > arch/riscv/include/asm/patch.h | 3 +-- > arch/riscv/kernel/alternative.c | 4 ++-- > arch/riscv/kernel/cpufeature.c | 2 +- > arch/riscv/kernel/jump_label.c | 2 +- > arch/riscv/kernel/patch.c | 24 +----------------------- > arch/riscv/net/bpf_jit_core.c | 4 ++-- > 8 files changed, 11 insertions(+), 34 deletions(-) > Reviewed-by: Andrew Jones From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B6EBEC3DA42 for ; Wed, 17 Jul 2024 13:15:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rlG4yP4YwD+tho06X7wsXvxnZuweEOkpML2HVA7Ezmw=; b=Fgy9MNryjoqm13 o2/yQjDfcYXB4FHQS2U2xEHXw0yUnw9Y7hlA+ASYcS7KO8E+OOhUEVFQx6Ysa6LLN9rD+PGV0X7kD gTiIoD5aEPylumG+oJjDAU7nuxQbrQMzxM+BC5iLvZQmoFwPJ+82VJpP9k06XPN8/6tnG+reDWi2S hlp2YGmfT74t4Mt/1lKLwa0DlvwwAl2xsEixF9r2/OKaOy0auLF8Cgc9IoH6Kw8hAv0nHns9y8kOh U9laH9CwvobPDsMXoqGhVCQ6ODKx/ipRC7n37FYS+wBD4s1r12TmEamZ/OyhQm/e6yz36mdY2hsVh cA5ddy3Rl/GtqhDDv7Ag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sU4VV-0000000DrfF-3xEx; Wed, 17 Jul 2024 13:15:45 +0000 Received: from mail-io1-xd32.google.com ([2607:f8b0:4864:20::d32]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sU4VS-0000000DreG-2M4N for linux-riscv@lists.infradead.org; Wed, 17 Jul 2024 13:15:44 +0000 Received: by mail-io1-xd32.google.com with SMTP id ca18e2360f4ac-8036ce6631bso39526239f.1 for ; Wed, 17 Jul 2024 06:15:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1721222141; x=1721826941; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=nfyN59SqKKWvXLU3CmJIUvS3Qc0ugEMt32zK3kDXEnU=; b=CbHIVHqKQFeV9IKxuB8rkoR1ILS9Orz2foh13YRBkUXTEsbjMfkLH/Q5ty41+E5dMK pBtNH9yPxVAZH2zplXqdVYulIhV5o7yZps7RVk+fIg7xsnOTqH7si/6F/A1779kqX0Nu KOU4gkkY7KPetRsK/vuSGRLdkA2EqxswV1pgJ9boMwi6t1BmEk3ZDsHu8q/TPIHWKXAi 0fiayV7inX3B3Q9uATLvYEGdwj7yF5FHoRVz4/C8f00dEC5U/mTVvuc1v5X2Ribc9s0V wlGueW9xPBy2XEmaoU9ZH4ilDXWV3KDKMyGS+wIIhTqUt4OVOhwbqovn6uBmZDmpIPf0 vxiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721222141; x=1721826941; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nfyN59SqKKWvXLU3CmJIUvS3Qc0ugEMt32zK3kDXEnU=; b=Zptiw6CRZ+LX3qQG9GQmOYKQWTYaRf7lfwLm9whPw+ToeTcUeVOSwQu4D/tHgAmSix MUgCn3Zhvz2LAlb/iT26HFrHMd4992/xApG8hJR3G/uF4cOYb3LsEKmsRPGWHmPPa9Ox zxqJ4o6tTlT764cHRt+Z+mV+QfaJnGZpWQpjyLuZCjU5b2UK6FNCWJW38Ahr4+O3hwbJ jtDF4yrdhY5W/5D7bbHzqTgspRwM4JsI0aYutMonTk9mKUThhLsycnrUdJHW40LJsyRr Rhic6Z0+Zf7qBlnXEHAXQGj853x+k/2Jpf5IP/inUqt4Q9UoM1qC+iUVYK2C0jS9V/2N XozA== X-Forwarded-Encrypted: i=1; AJvYcCUEVPVYPnfA8Q4vQWa0CV1u9MYnwr5ESZsTRpeOPEDkJWWRJWyE8cYuFoLGQgIMA93YG1DO4Bv9tw+C60Qfgz0LPL1CR95SDtdtm3cjZVNw X-Gm-Message-State: AOJu0YyRedZ8tM0VsImqVkgu6HWbE43k+S9I9jiEv1kRBojpj2wAGxUv /9q0/zaxQVRSImb5zsRo8+tj7kWxPXNu+0VZihpXV28LpJ6JAlfzGP8bL2zzCEc= X-Google-Smtp-Source: AGHT+IGqABt+N2by4fsdmIqsdoYWgZufcwOnrxKz5lnVlQ+PsNG/iBjeIJbo82SPl4wG/8emOYWz6A== X-Received: by 2002:a05:6602:1406:b0:7f9:1b3b:8465 with SMTP id ca18e2360f4ac-817109e76cbmr216963839f.11.1721222141068; Wed, 17 Jul 2024 06:15:41 -0700 (PDT) Received: from localhost ([140.82.166.162]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4c210f21be4sm658490173.91.2024.07.17.06.15.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jul 2024 06:15:40 -0700 (PDT) Date: Wed, 17 Jul 2024 08:15:40 -0500 From: Andrew Jones To: Alexandre Ghiti Cc: Paul Walmsley , Palmer Dabbelt , Albert Ou , Samuel Holland , Peter Zijlstra , Josh Poimboeuf , Jason Baron , Steven Rostedt , Ard Biesheuvel , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= , Pu Lehui , Puranjay Mohan , Luke Nelson , Xi Wang , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, Geert Uytterhoeven Subject: Re: [PATCH] riscv: patch: Remove redundant functions Message-ID: <20240717-515ffec38da9b1f5df03e42c@orel> References: <20240717084102.150914-1-alexghiti@rivosinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240717084102.150914-1-alexghiti@rivosinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240717_061542_622840_2655CABC X-CRM114-Status: GOOD ( 10.91 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Wed, Jul 17, 2024 at 10:41:02AM GMT, Alexandre Ghiti wrote: > Commit edf2d546bfd6f5c4 ("riscv: patch: Flush the icache right after > patching to avoid illegal insns") removed the last differences between > patch_text_set_nosync() and patch_insn_set(), and between > patch_text_nosync() and patch_insn_write(). > > So remove the redundant *_nosync() functions. > > Reported-by: Geert Uytterhoeven > Closes: https://lore.kernel.org/linux-riscv/CAMuHMdUwx=rU2MWhFTE6KhYHm64phxx2Y6u05-aBLGfeG5696A@mail.gmail.com/ > Signed-off-by: Alexandre Ghiti > --- > arch/riscv/errata/sifive/errata.c | 4 ++-- > arch/riscv/errata/thead/errata.c | 2 +- > arch/riscv/include/asm/patch.h | 3 +-- > arch/riscv/kernel/alternative.c | 4 ++-- > arch/riscv/kernel/cpufeature.c | 2 +- > arch/riscv/kernel/jump_label.c | 2 +- > arch/riscv/kernel/patch.c | 24 +----------------------- > arch/riscv/net/bpf_jit_core.c | 4 ++-- > 8 files changed, 11 insertions(+), 34 deletions(-) > Reviewed-by: Andrew Jones _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv