All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: Eric Le Bihan <eric.le.bihan.dev@free.fr>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 4/4] package/fwupd: new package
Date: Wed, 17 Jul 2024 00:17:58 +0200	[thread overview]
Message-ID: <20240717001758.65e4c207@windsurf> (raw)
In-Reply-To: <CADvTj4pF77Ci9k+DjaXz63DDqrJRatjSUD8kFdYz56MnP3sHwQ@mail.gmail.com>

On Tue, 16 Jul 2024 13:56:56 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:

> So udevdir is required to be defined if udev is not present due to this:
> https://github.com/fwupd/fwupd/blob/1.9.21/meson.build#L276-L280
> 
> But installation is actually conditional here based on gudev:
> https://github.com/fwupd/fwupd/blob/1.9.21/data/meson.build#L62-L64
> 
> So always setting -Dudevdir=/usr/lib/udev seems to be the best option
> as the build system always wants that defined even when not used.

Thanks for the explanation. Would perhaps be good to submit a bug
upstream, or even better a fix. Makes no sense to have to define
udevdir if it doesn't get used.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2024-07-16 22:18 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-11 15:21 [Buildroot] [PATCH v2 1/4] package/libjcat: new package James Hilliard
2024-06-11 15:22 ` [Buildroot] [PATCH v2 2/4] package/fwupd-efi: " James Hilliard
2024-06-11 15:22 ` [Buildroot] [PATCH v2 3/4] package/flashrom: install to staging with meson James Hilliard
2024-07-16 12:40   ` Thomas Petazzoni via buildroot
2024-06-11 15:22 ` [Buildroot] [PATCH v2 4/4] package/fwupd: new package James Hilliard
2024-07-16 12:17   ` Thomas Petazzoni via buildroot
2024-07-16 17:55     ` James Hilliard
2024-07-16 19:47       ` Thomas Petazzoni via buildroot
2024-07-16 19:56         ` James Hilliard
2024-07-16 22:17           ` Thomas Petazzoni via buildroot [this message]
2024-07-18 16:03             ` James Hilliard
2024-07-16 12:39 ` [Buildroot] [PATCH v2 1/4] package/libjcat: " Thomas Petazzoni via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240717001758.65e4c207@windsurf \
    --to=buildroot@buildroot.org \
    --cc=eric.le.bihan.dev@free.fr \
    --cc=james.hilliard1@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.