From: Jakub Kicinski <kuba@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
alexanderduyck@fb.com, kernel-team@meta.com
Subject: Re: [PATCH net] eth: fbnic: don't build the driver when skb has more than 25 frags
Date: Wed, 17 Jul 2024 07:12:18 -0700 [thread overview]
Message-ID: <20240717071218.72ec1bc6@kernel.org> (raw)
In-Reply-To: <43bc03f0-5e5a-4265-898b-8ca526d6cc75@redhat.com>
On Wed, 17 Jul 2024 15:44:09 +0200 Paolo Abeni wrote:
> I think that with aarch MAX_SKB_FRAGS should be max 21. Aarch cacheline
> size is 128, right? The frag independent part of skb_shared_info takes
> 48 bytes, and sizeof(skb_frag_t) == 16:
>
> (512 - 128 - 48)/16 = 21
Hm, my grep foo must be low, I don't see aarch64 with 128B cache lines.
But I do see powerpc, so we can stick to 21 to be safe.
next prev parent reply other threads:[~2024-07-17 14:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-17 13:37 [PATCH net] eth: fbnic: don't build the driver when skb has more than 25 frags Jakub Kicinski
2024-07-17 13:44 ` Paolo Abeni
2024-07-17 14:12 ` Jakub Kicinski [this message]
2024-07-17 14:50 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240717071218.72ec1bc6@kernel.org \
--to=kuba@kernel.org \
--cc=alexanderduyck@fb.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel-team@meta.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.