From: Jakub Kicinski <kuba@kernel.org>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: "Mogilappagari, Sudheer" <sudheer.mogilappagari@intel.com>,
Michal Kubecek <mkubecek@suse.cz>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Wei Fang <wei.fang@nxp.com>,
"Samudrala, Sridhar" <sridhar.samudrala@intel.com>
Subject: Re: Netlink handler for ethtool --show-rxfh breaks driver compatibility
Date: Wed, 17 Jul 2024 09:45:01 -0700 [thread overview]
Message-ID: <20240717094501.2e60075d@kernel.org> (raw)
In-Reply-To: <20240715154653.kcqcazsndp4nrqqh@skbuf>
On Mon, 15 Jul 2024 18:46:53 +0300 Vladimir Oltean wrote:
> > They can provide a different number? Which number is the user
> > supposed to trust? Out of the 4 APIs we have? Or the NIC has
> > a different ring count depending on the API?
>
> To stay on point on GRXRINGS vs GCHANNELS, "man ethtool" does say
> "A channel is an IRQ and the set of queues that can trigger that IRQ."
> Doesn't sound either (a) identical or (b) that you can recover the # of
> rings from the # of channels, unless you make an assumption about how
> they are distributed to IRQs...
A bit short on time to write a proper reply, but thinking some more
about it, I think you're right. The choice of channels is not great.
It works today, but if we start stacking multiple Rx queues on a single
IRQ one day - things will get complicated. So let's go back to GRXRINGS
for now.
prev parent reply other threads:[~2024-07-17 16:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-11 11:45 Netlink handler for ethtool --show-rxfh breaks driver compatibility Vladimir Oltean
2024-07-15 7:37 ` Mogilappagari, Sudheer
2024-07-15 11:58 ` Vladimir Oltean
2024-07-15 13:11 ` Jakub Kicinski
2024-07-15 13:22 ` Vladimir Oltean
2024-07-15 13:39 ` Jakub Kicinski
2024-07-15 15:05 ` Vladimir Oltean
2024-07-15 15:26 ` Jakub Kicinski
2024-07-15 15:45 ` Michal Kubecek
2024-07-15 15:46 ` Vladimir Oltean
2024-07-17 16:45 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240717094501.2e60075d@kernel.org \
--to=kuba@kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=sridhar.samudrala@intel.com \
--cc=sudheer.mogilappagari@intel.com \
--cc=vladimir.oltean@nxp.com \
--cc=wei.fang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.