From: Petr Vorel <pvorel@suse.cz>
To: Li Wang <liwang@redhat.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [RFC PATCH 1/2] Add support for mixing C and shell code
Date: Wed, 17 Jul 2024 19:51:50 +0200 [thread overview]
Message-ID: <20240717175150.GA690776@pevik> (raw)
In-Reply-To: <CAEemH2f4sO40tJxT2wokw=SDaeAvNhR-z8NOqW0=xWSKSv3Wsg@mail.gmail.com>
Hi all,
> On Wed, Jul 17, 2024 at 4:49 PM Cyril Hrubis <chrubis@suse.cz> wrote:
> > Hi!
> > > Since execvpe() is a GNU extension, we need to ensure that
> > > we are compiling with GNU extensions enabled.
> > > add this line into the head of tst_test.c:
> > > #define _GNU_SOURCE
Good, you already noticed.
> > As for the execvpe() I've used that for the prototype but I'm unsure if
> > it could be used in the final product, since this is the test library it
> > has to compile on all kinds of libc out there. It looks like musl does
> > support it but I haven't checked Android bionic.
> > So we may need to write our own implemtantion on the top of the execve()
> > syscall. But that should be as easy as getting the path to the script
> > before we pass it to execve().
It supports it. It looks like even without _GNU_SOURCE:
https://android.googlesource.com/platform/bionic.git/+/refs/heads/main/libc/include/unistd.h#142
But better to keep Edward in loop.
> Indeed. We need to create a ltp_execvpe() based on execve().
So there will be v2, right?
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-07-17 17:52 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-16 15:36 [LTP] [RFC PATCH 0/2] Shell test library v3 Cyril Hrubis
2024-07-16 15:36 ` [LTP] [RFC PATCH 1/2] Add support for mixing C and shell code Cyril Hrubis
2024-07-17 8:33 ` Li Wang
2024-07-17 8:41 ` Cyril Hrubis
2024-07-17 10:07 ` Li Wang
2024-07-17 8:52 ` Cyril Hrubis
2024-07-17 10:21 ` Li Wang
2024-07-17 17:51 ` Petr Vorel [this message]
2024-07-17 17:55 ` Petr Vorel
2024-07-17 18:13 ` Cyril Hrubis
2024-07-18 12:43 ` Petr Vorel
2024-07-18 13:03 ` Cyril Hrubis
2024-07-18 12:57 ` Petr Vorel
2024-07-18 13:07 ` Cyril Hrubis
2024-07-18 13:15 ` Petr Vorel
2024-07-24 9:37 ` Martin Doucha
2024-07-24 9:47 ` Cyril Hrubis
2024-07-24 9:53 ` Martin Doucha
2024-07-24 10:05 ` Cyril Hrubis
2024-07-30 9:49 ` Cyril Hrubis
2024-07-16 15:36 ` [LTP] [RFC PATCH 2/2] testcaes/lib: Add shell loader Cyril Hrubis
2024-07-24 12:54 ` Martin Doucha
2024-07-25 11:02 ` Petr Vorel
2024-07-25 16:01 ` Martin Doucha
2024-07-25 21:44 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240717175150.GA690776@pevik \
--to=pvorel@suse.cz \
--cc=liwang@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.