From: SeongJae Park <sj@kernel.org>
To: David Gow <davidgow@google.com>
Cc: SeongJae Park <sj@kernel.org>, Kees Cook <kees@kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
Eric Biederman <ebiederm@xmission.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH] execve: Move KUnit tests to tests/ subdirectory
Date: Thu, 18 Jul 2024 10:46:01 -0700 [thread overview]
Message-ID: <20240718174601.64851-1-sj@kernel.org> (raw)
In-Reply-To: <CABVgOSmKwPq7JEpHfS6sbOwsR0B-DBDk_JP-ZD9s9ZizvpUjbQ@mail.gmail.com>
On Thu, 18 Jul 2024 14:04:14 +0800 David Gow <davidgow@google.com> wrote:
> On Thu, 18 Jul 2024 at 05:22, Kees Cook <kees@kernel.org> wrote:
> >
> > Move the exec KUnit tests into a separate directory to avoid polluting
> > the local directory namespace. Additionally update MAINTAINERS for the
> > new files and mark myself as Maintainer.
> >
> > Signed-off-by: Kees Cook <kees@kernel.org>
> > ---
> > I'll toss this into -next and send it to Linus before -rc1 closes.
> > ---
>
> With s/_test/_kunit (once the docs changes are sorted), this looks good.
I have no strong opinion, but I agree to David's rationale [1] on preferrence
of _kunit overall, and would prefer having a consistent and simple rule.
[1] https://lore.kernel.org/CABVgOS=B29PcKyhVXtTk47k_BhjSaoxL8eF15fVhzty_0syeSQ@mail.gmail.com
>
> Reviewed-by: David Gow <davidgow@google.com>
Reviewed-by: SeongJae Park <sj@kernel.org>
Thanks,
SJ
[...]
prev parent reply other threads:[~2024-07-18 17:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-17 21:22 [PATCH] execve: Move KUnit tests to tests/ subdirectory Kees Cook
2024-07-18 6:04 ` David Gow
2024-07-18 17:46 ` SeongJae Park [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240718174601.64851-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=brauner@kernel.org \
--cc=davidgow@google.com \
--cc=ebiederm@xmission.com \
--cc=jack@suse.cz \
--cc=kees@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.