All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam@gmail.com>
To: broonie@kernel.org
Cc: linux-spi@vger.kernel.org, otavio.salvador@ossystems.com.br,
	heiko@sntech.de, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, devicetree@vger.kernel.org,
	Fabio Estevam <festevam@gmail.com>,
	Conor Dooley <conor.dooley@microchip.com>
Subject: [PATCH 3/3] ARM: dts: rockchip: rv1108-elgin-r1: Do not describe unexisting DAC device
Date: Thu, 18 Jul 2024 17:05:40 -0300	[thread overview]
Message-ID: <20240718200540.955370-3-festevam@gmail.com> (raw)
In-Reply-To: <20240718200540.955370-1-festevam@gmail.com>

There is no DAC connected to the SPI bus of the Elgin RV1108 R1 board.

There is an LCD controlled via SPI though.

Properly describe it by adding the "elgin,spi-lcd" compatible
string.

Reported-by: Conor Dooley <conor.dooley@microchip.com>
Closes: https://lore.kernel.org/linux-arm-kernel/20240717-parrot-malt-83cc04bf6b36@spud/
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
Hi Heiko,

Conor sent a patch removing the rohm,dh2228fv entry from rv1108-elgin-r1.dts:

https://lore.kernel.org/linux-arm-kernel/20240717-parrot-malt-83cc04bf6b36@spud/

If you prefer, I can send a patch on top of his.

Or you can apply this one instead.

 arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts b/arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts
index 2d9994379eb2..971bb617e845 100644
--- a/arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts
+++ b/arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts
@@ -168,8 +168,8 @@ &spi {
 	pinctrl-0 = <&spim1_clk &spim1_cs0 &spim1_tx &spim1_rx>;
 	status = "okay";
 
-	dh2228fv: dac@0 {
-		compatible = "rohm,dh2228fv";
+	display: display@0 {
+		compatible = "elgin,spi-lcd";
 		reg = <0>;
 		spi-max-frequency = <24000000>;
 		spi-cpha;
-- 
2.34.1


  parent reply	other threads:[~2024-07-18 20:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-18 20:05 [PATCH 1/3] dt-bindings: trivial-devices: Document elgin,spi-lcd Fabio Estevam
2024-07-18 20:05 ` [PATCH 2/3] spi: spidev: Add an entry for "elgin,spi-lcd" Fabio Estevam
2024-07-18 20:05 ` Fabio Estevam [this message]
2024-07-19  8:02   ` [PATCH 3/3] ARM: dts: rockchip: rv1108-elgin-r1: Do not describe unexisting DAC device Heiko Stübner
2024-07-19  8:30     ` Conor Dooley
2024-07-19  8:42 ` [PATCH 1/3] dt-bindings: trivial-devices: Document elgin,spi-lcd Conor Dooley
2024-07-19 14:38   ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240718200540.955370-3-festevam@gmail.com \
    --to=festevam@gmail.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=conor.dooley@microchip.com \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=otavio.salvador@ossystems.com.br \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.