From: Fabio Estevam <festevam@gmail.com>
To: broonie@kernel.org
Cc: linux-spi@vger.kernel.org, otavio.salvador@ossystems.com.br,
heiko@sntech.de, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Fabio Estevam <festevam@gmail.com>,
Conor Dooley <conor.dooley@microchip.com>
Subject: [PATCH v2 3/3] ARM: dts: rockchip: rv1108-elgin-r1: Do not describe unexisting DAC device
Date: Fri, 19 Jul 2024 08:12:10 -0300 [thread overview]
Message-ID: <20240719111210.1287783-3-festevam@gmail.com> (raw)
In-Reply-To: <20240719111210.1287783-1-festevam@gmail.com>
There is no DAC connected to the SPI bus of the Elgin RV1108 R1 board.
There is a JG10309-01 LCD controlled via SPI though.
Properly describe it by adding the "elgin,jg10309-01" compatible
string.
Reported-by: Conor Dooley <conor.dooley@microchip.com>
Closes: https://lore.kernel.org/linux-arm-kernel/20240717-parrot-malt-83cc04bf6b36@spud/
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
Changes since v1:
- Use a more specific compatible string. (Conor)
arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts b/arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts
index 2d9994379eb2..971bb617e845 100644
--- a/arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts
+++ b/arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts
@@ -168,8 +168,8 @@ &spi {
pinctrl-0 = <&spim1_clk &spim1_cs0 &spim1_tx &spim1_rx>;
status = "okay";
- dh2228fv: dac@0 {
- compatible = "rohm,dh2228fv";
+ display: display@0 {
+ compatible = "elgin,jg10309-01";
reg = <0>;
spi-max-frequency = <24000000>;
spi-cpha;
--
2.34.1
next prev parent reply other threads:[~2024-07-19 11:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-19 11:12 [PATCH v2 1/3] dt-bindings: trivial-devices: Document elgin,jg10309-01 Fabio Estevam
2024-07-19 11:12 ` [PATCH v2 2/3] spi: spidev: Add an entry for elgin,jg10309-01 Fabio Estevam
2024-08-10 21:22 ` Heiko Stübner
2024-07-19 11:12 ` Fabio Estevam [this message]
2024-08-10 21:23 ` [PATCH v2 3/3] ARM: dts: rockchip: rv1108-elgin-r1: Do not describe unexisting DAC device Heiko Stübner
2024-08-29 17:31 ` Fabio Estevam
2024-08-29 17:40 ` Heiko Stübner
2024-07-19 14:45 ` [PATCH v2 1/3] dt-bindings: trivial-devices: Document elgin,jg10309-01 Conor Dooley
2024-07-26 21:57 ` Heiko Stübner
2024-08-05 13:18 ` Fabio Estevam
2024-08-05 22:05 ` Conor Dooley
2024-07-23 2:57 ` Rob Herring (Arm)
2024-08-10 21:22 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240719111210.1287783-3-festevam@gmail.com \
--to=festevam@gmail.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=otavio.salvador@ossystems.com.br \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.