From: Yazen Ghannam <yazen.ghannam@amd.com>
To: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
Bjorn Helgaas <helgaas@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
Peter Anvin <hpa@zytor.com>, Bjorn Helgaas <bhelgaas@google.com>,
Muralidhara M K <muralidhara.mk@amd.com>,
Avadhut Naik <Avadhut.Naik@amd.com>,
Mario Limonciello <mario.limonciello@amd.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
x86@kernel.org
Subject: Re: [PATCH v1] x86/amd_nb: Add new PCI IDs for AMD family 0x1a model 60h
Date: Fri, 19 Jul 2024 10:28:03 -0400 [thread overview]
Message-ID: <20240719142803.GB17507@yaz-khff2.amd.com> (raw)
In-Reply-To: <95ea23bf-b628-4fdb-a4ef-0029f9df2ec2@amd.com>
On Thu, Jul 18, 2024 at 11:37:31PM +0530, Shyam Sundar S K wrote:
>
>
> On 7/18/2024 22:43, Bjorn Helgaas wrote:
> > On Thu, Jul 18, 2024 at 07:32:58PM +0530, Shyam Sundar S K wrote:
> >> Add the new PCI Device IDs to the root IDs and misc ids list to support
> >> new generation of AMD 1Ah family 60h Models of processors.
> >>
> >> Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
> >> ---
> >> (As the amd_nb functions are used by PMC and PMF drivers, without these IDs
> >> being present AMD PMF/PMC probe shall fail.)
> >
> > Is there any plan for making this generic so a kernel update is not
> > needed? Obviously the *functionality* is not changed by this patch,
> > so having to add a device ID for every new processor just makes work
> > for distros and users.
>
> Regarding AMD processors, there are numerous PCI IDs defined in the
> PPRs/BKDG. I'm not sure if there's a generic way to address this
> without a kernel update.
>
One of our colleagues is working on a possible solution. It'll likely
use device types and class codes so we don't need to add individual PCI
IDs for each new product.
Thanks,
Yazen
prev parent reply other threads:[~2024-07-19 14:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-18 14:02 [PATCH v1] x86/amd_nb: Add new PCI IDs for AMD family 0x1a model 60h Shyam Sundar S K
2024-07-18 15:43 ` Yazen Ghannam
2024-07-18 16:49 ` Shyam Sundar S K
2024-07-19 14:18 ` Yazen Ghannam
2024-07-18 17:13 ` Bjorn Helgaas
2024-07-18 18:07 ` Shyam Sundar S K
2024-07-19 14:28 ` Yazen Ghannam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240719142803.GB17507@yaz-khff2.amd.com \
--to=yazen.ghannam@amd.com \
--cc=Avadhut.Naik@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=helgaas@kernel.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mingo@redhat.com \
--cc=muralidhara.mk@amd.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.