From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C04591459F9; Fri, 19 Jul 2024 16:57:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721408249; cv=none; b=XfpFGDqPZKPyK6A7mMMuvlriCI+IwC4+B4i6bfbKuttViLdLfE6OmgR3TolKD61FPoW/NCrHyWg75AayFIcqAznHMyFFYF/eD9uxmAUqB5O70MZMsmri3BP8Awd1q3wzmRTAsu5zf83xPdqNhOa5ywc1NCoy+vcSWBWIrH7EECA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721408249; c=relaxed/simple; bh=n5lsZKENEbYZNCmrS19ZUSn5JNrR4eNLIoHqhtfAN4U=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=p0eREY6BuRa3cZSWr6I7RAC8dgaEME34QgRnKPu7H1Lc/Ss7IV7ev9aojQduM6RYpKNk/A/+IUVE148SlpGi0UtXv0AbVNui6btqdLk2D2SkKc9JlOD8fWp634urcF5w6gBFOUnxgSO/e8RfONmvb+39Hj6FEi61FlwYGU3+w+E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4WQbQ30Sw7z6K8lH; Sat, 20 Jul 2024 00:55:07 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id 84DA0140A79; Sat, 20 Jul 2024 00:57:24 +0800 (CST) Received: from localhost (10.48.157.16) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 19 Jul 2024 17:57:23 +0100 Date: Fri, 19 Jul 2024 17:57:22 +0100 From: Jonathan Cameron To: Mike Rapoport CC: , Alexander Gordeev , Andreas Larsson , "Andrew Morton" , Arnd Bergmann , "Borislav Petkov" , Catalin Marinas , Christophe Leroy , Dan Williams , Dave Hansen , David Hildenbrand , "David S. Miller" , Greg Kroah-Hartman , Heiko Carstens , Huacai Chen , Ingo Molnar , Jiaxun Yang , "John Paul Adrian Glaubitz" , Michael Ellerman , Palmer Dabbelt , "Rafael J. Wysocki" , Rob Herring , "Thomas Bogendoerfer" , Thomas Gleixner , Vasily Gorbik , Will Deacon , , , , , , , , , , , , , , , Subject: Re: [PATCH 11/17] x86/numa: numa_{add,remove}_cpu: make cpu parameter unsigned Message-ID: <20240719175722.000016f8@Huawei.com> In-Reply-To: <20240716111346.3676969-12-rppt@kernel.org> References: <20240716111346.3676969-1-rppt@kernel.org> <20240716111346.3676969-12-rppt@kernel.org> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml500001.china.huawei.com (7.191.163.213) To lhrpeml500005.china.huawei.com (7.191.163.240) On Tue, 16 Jul 2024 14:13:40 +0300 Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > CPU id cannot be negative. > > Making it unsigned also aligns with declarations in > include/asm-generic/numa.h used by arm64 and riscv and allows sharing > numa emulation code with these architectures. > > Signed-off-by: Mike Rapoport (Microsoft) Makes sense for both reasons. FWIW given how simple it is. Maybe worth bringing a few more functions inline with this? Probably something for another day given we don't care about the inconsistency for this series. Reviewed-by: Jonathan Cameron From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B87BDC3DA59 for ; Fri, 19 Jul 2024 16:57:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Xm4hPGEet55b3WILURinUGzZh/HWv/gVdC8HM5MOHWw=; b=SiLJU4SONsRx4v HHDy/rPCZfJOXu5UOfIK4XlTC5gfWs2HBJmrAfVidBspeTIcUbS9LpTfZZU0hGtEeKZmMWiWaqXox qHKQAau+I1mtIuPzK3KftIr/IdSZl9yyADkFLs2gcpaxp5SvjivCMDcXyrmz25EZMN3nKh9wVb9k0 qtQ4Eu/7zz26M1nw0CLRdWJxAIdkCQejUKWEM4fwK+dhXKUesRqHStM2eVS3Ar5sPKaSAIAPq2Hnq QrUZCkSxRwKLu0YZDqVVUPi6p3wPAmc+SPamwGo6h0s8hMoZv4KSln8B4xt57bYfBWQVZNzGiagZP 4aQacpg/vEYtyTxg8kpQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sUqva-00000003Lch-2HBV; Fri, 19 Jul 2024 16:57:54 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sUqvC-00000003LVf-3BGv; Fri, 19 Jul 2024 16:57:32 +0000 Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4WQbQ30Sw7z6K8lH; Sat, 20 Jul 2024 00:55:07 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id 84DA0140A79; Sat, 20 Jul 2024 00:57:24 +0800 (CST) Received: from localhost (10.48.157.16) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 19 Jul 2024 17:57:23 +0100 Date: Fri, 19 Jul 2024 17:57:22 +0100 From: Jonathan Cameron To: Mike Rapoport CC: , Alexander Gordeev , Andreas Larsson , "Andrew Morton" , Arnd Bergmann , "Borislav Petkov" , Catalin Marinas , Christophe Leroy , Dan Williams , Dave Hansen , David Hildenbrand , "David S. Miller" , Greg Kroah-Hartman , Heiko Carstens , Huacai Chen , Ingo Molnar , Jiaxun Yang , "John Paul Adrian Glaubitz" , Michael Ellerman , Palmer Dabbelt , "Rafael J. Wysocki" , Rob Herring , "Thomas Bogendoerfer" , Thomas Gleixner , Vasily Gorbik , Will Deacon , , , , , , , , , , , , , , , Subject: Re: [PATCH 11/17] x86/numa: numa_{add,remove}_cpu: make cpu parameter unsigned Message-ID: <20240719175722.000016f8@Huawei.com> In-Reply-To: <20240716111346.3676969-12-rppt@kernel.org> References: <20240716111346.3676969-1-rppt@kernel.org> <20240716111346.3676969-12-rppt@kernel.org> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 X-Originating-IP: [10.48.157.16] X-ClientProxiedBy: lhrpeml500001.china.huawei.com (7.191.163.213) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240719_095731_049255_CDA9EEFA X-CRM114-Status: UNSURE ( 7.55 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Tue, 16 Jul 2024 14:13:40 +0300 Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > CPU id cannot be negative. > > Making it unsigned also aligns with declarations in > include/asm-generic/numa.h used by arm64 and riscv and allows sharing > numa emulation code with these architectures. > > Signed-off-by: Mike Rapoport (Microsoft) Makes sense for both reasons. FWIW given how simple it is. Maybe worth bringing a few more functions inline with this? Probably something for another day given we don't care about the inconsistency for this series. Reviewed-by: Jonathan Cameron _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 158E2C3DA59 for ; Fri, 19 Jul 2024 16:57:52 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4WQbTB4mhkz3dV9 for ; Sat, 20 Jul 2024 02:57:50 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=huawei.com (client-ip=185.176.79.56; helo=frasgout.his.huawei.com; envelope-from=jonathan.cameron@huawei.com; receiver=lists.ozlabs.org) Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4WQbSm1K1kz3cZ9 for ; Sat, 20 Jul 2024 02:57:28 +1000 (AEST) Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4WQbQ30Sw7z6K8lH; Sat, 20 Jul 2024 00:55:07 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id 84DA0140A79; Sat, 20 Jul 2024 00:57:24 +0800 (CST) Received: from localhost (10.48.157.16) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 19 Jul 2024 17:57:23 +0100 Date: Fri, 19 Jul 2024 17:57:22 +0100 From: Jonathan Cameron To: Mike Rapoport Subject: Re: [PATCH 11/17] x86/numa: numa_{add,remove}_cpu: make cpu parameter unsigned Message-ID: <20240719175722.000016f8@Huawei.com> In-Reply-To: <20240716111346.3676969-12-rppt@kernel.org> References: <20240716111346.3676969-1-rppt@kernel.org> <20240716111346.3676969-12-rppt@kernel.org> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.48.157.16] X-ClientProxiedBy: lhrpeml500001.china.huawei.com (7.191.163.213) To lhrpeml500005.china.huawei.com (7.191.163.240) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nvdimm@lists.linux.dev, x86@kernel.org, Andreas Larsson , Catalin Marinas , Dave Hansen , David Hildenbrand , Jiaxun Yang , linux-mips@vger.kernel.org, linux-mm@kvack.org, sparclinux@vger.kernel.org, Alexander Gordeev , Will Deacon , Thomas Gleixner , linux-arch@vger.kernel.org, Rob Herring , Vasily Gorbik , linux-sh@vger.kernel.org, Huacai Chen , Christophe Leroy , linux-acpi@vger.kernel.org, Ingo Molnar , devicetree@vger.kernel.org, Arnd Bergmann , linux-s390@vger.kernel.org, Heiko Carstens , Borislav Petkov , linux-cxl@vger.kernel.org, loongarch@lists.linux.dev, John Paul Adrian Glaubitz , Dan Williams , linux-arm-kernel@lists.infradead.org, Thomas Bogendoerfer , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, Palmer Dabbelt , "Rafael J. Wysocki" , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, 16 Jul 2024 14:13:40 +0300 Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > CPU id cannot be negative. > > Making it unsigned also aligns with declarations in > include/asm-generic/numa.h used by arm64 and riscv and allows sharing > numa emulation code with these architectures. > > Signed-off-by: Mike Rapoport (Microsoft) Makes sense for both reasons. FWIW given how simple it is. Maybe worth bringing a few more functions inline with this? Probably something for another day given we don't care about the inconsistency for this series. Reviewed-by: Jonathan Cameron