Re: [PATCH 2/2] btrfs-progs: set subvol uuids when converting

[Josef Bacik <josef@toxicpanda.com>]

On Fri, Jul 19, 2024 at 04:03:24PM +0100, Mark Harmstone wrote:
> Currently when using btrfs-convert, neither the main subvolume nor the
> image subvolume get uuids assigned, nor is the uuid tree created.
> 
> Signed-off-by: Mark Harmstone <maharmstone@fb.com>
> ---
>  common/root-tree-utils.c | 29 +++++++++++++++++++++++++++++
>  common/root-tree-utils.h |  1 +
>  convert/common.c         | 14 +++++++++-----
>  convert/main.c           |  8 +++++++-
>  mkfs/main.c              | 29 -----------------------------
>  5 files changed, 46 insertions(+), 35 deletions(-)
> 
> diff --git a/common/root-tree-utils.c b/common/root-tree-utils.c
> index f9343304..9495178c 100644
> --- a/common/root-tree-utils.c
> +++ b/common/root-tree-utils.c
> @@ -59,6 +59,35 @@ error:
>  	return ret;
>  }
>  
> +int create_uuid_tree(struct btrfs_trans_handle *trans)

If we're exporting a new thing then it needs to be renamed to
btrfs_create_uuid_tree.

Also a convert test for this would be good, to validate we're getting the UUID
tree on convert.  Thanks,

Josef