From: Luca Ceresoli via buildroot <buildroot@buildroot.org>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Brandon Maier <brandon.maier@collins.com>,
Brandon Maier via buildroot <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH v2] boot/uboot: fix Kconfig warning for DEFAULT_ENV_FILE
Date: Sat, 20 Jul 2024 11:36:05 +0200 [thread overview]
Message-ID: <20240720113605.3e39316b@booty> (raw)
In-Reply-To: <20240719223224.2b67a89f@windsurf>
Hi Thomas, Brandon,
On Fri, 19 Jul 2024 22:32:24 +0200
Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
> Hello,
>
> On Fri, 19 Jul 2024 14:50:26 +0000
> Brandon Maier via buildroot <buildroot@buildroot.org> wrote:
>
> > +config BR2_TARGET_UBOOT_DEFAULT_ENV_FILE_HIDDEN
>
> No need to resend for that, and even though I know I was the one
> suggesting this name, I don't actually like it. Maybe:
>
> config BR2_TARGET_UBOOT_DEFAULT_ENV_FILE_ENABLED
>
> or something like that?
I agree _HIDDEN is not the best possible name. In my v1 it was
BR2_TARGET_UBOOT_USE_DEFAULT_ENV_FILE, but that was a visible option to
"USE" (imperative) would make sense. Now it might be OK for a hidden
option, but perhaps _ENABLED is even better so my vote for that.
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-07-20 9:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-19 14:50 [Buildroot] [PATCH v2] boot/uboot: fix Kconfig warning for DEFAULT_ENV_FILE Brandon Maier via buildroot
2024-07-19 16:33 ` Luca Ceresoli via buildroot
2024-07-19 20:32 ` Thomas Petazzoni via buildroot
2024-07-20 9:36 ` Luca Ceresoli via buildroot [this message]
2024-07-22 16:29 ` Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240720113605.3e39316b@booty \
--to=buildroot@buildroot.org \
--cc=brandon.maier@collins.com \
--cc=luca.ceresoli@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.