From: Stephen Hemminger <stephen@networkplumber.org>
To: "Robin Jarry" <rjarry@redhat.com>
Cc: "Morten Brørup" <mb@smartsharesystems.com>,
"Vladimir Medvedkin" <medvedkinv@gmail.com>,
bruce.richardson@intel.com,
"Konstantin Ananyev" <konstantin.ananyev@huawei.com>,
dev@dpdk.org, "Sunil Kumar Kori" <skori@marvell.com>,
"Rakesh Kudurumalla" <rkudurumalla@marvell.com>,
"Wisam Jaddo" <wisamm@nvidia.com>,
"Cristian Dumitrescu" <cristian.dumitrescu@intel.com>,
"Konstantin Ananyev" <konstantin.v.ananyev@yandex.ru>,
"Akhil Goyal" <gakhil@marvell.com>,
"Fan Zhang" <fanzhang.oss@gmail.com>,
"Yipeng Wang" <yipeng1.wang@intel.com>,
"Sameh Gobriel" <sameh.gobriel@intel.com>,
"Nithin Dabilpuram" <ndabilpuram@marvell.com>,
"Kiran Kumar K" <kirankumark@marvell.com>,
"Satha Rao" <skoteshwar@marvell.com>,
"Harman Kalra" <hkalra@marvell.com>,
"Ankur Dwivedi" <adwivedi@marvell.com>,
"Anoob Joseph" <anoobj@marvell.com>,
"Tejasree Kondoj" <ktejasree@marvell.com>,
"Gagandeep Singh" <g.singh@nxp.com>,
"Hemant Agrawal" <hemant.agrawal@nxp.com>,
"Ajit Khaparde" <ajit.khaparde@broadcom.com>,
"Somnath Kotur" <somnath.kotur@broadcom.com>,
"Chas Williams" <chas3@att.com>,
"Min Hu (Connor)" <humin29@huawei.com>,
"Potnuri Bharat Teja" <bharat@chelsio.com>,
"Sachin Saxena" <sachin.saxena@nxp.com>,
"Xiaoyun Wang" <cloud.wangxiaoyun@huawei.com>,
"Jie Hai" <haijie1@huawei.com>,
"Yisen Zhuang" <yisen.zhuang@huawei.com>,
"Jingjing Wu" <jingjing.wu@intel.com>,
"Dariusz Sosnowski" <dsosnowski@nvidia.com>,
"Viacheslav Ovsiienko" <viacheslavo@nvidia.com>,
"Bing Zhao" <bingz@nvidia.com>, "Ori Kam" <orika@nvidia.com>,
"Suanming Mou" <suanmingm@nvidia.com>,
"Matan Azrad" <matan@nvidia.com>,
"Chaoyong He" <chaoyong.he@corigine.com>,
"Devendra Singh Rawat" <dsinghrawat@marvell.com>,
"Alok Prasad" <palok@marvell.com>,
"Andrew Rybchenko" <andrew.rybchenko@oktetlabs.ru>,
"Jiawen Wu" <jiawenwu@trustnetic.com>,
"Jian Wang" <jianwang@trustnetic.com>,
"Thomas Monjalon" <thomas@monjalon.net>,
"Ferruh Yigit" <ferruh.yigit@amd.com>,
"Jiayu Hu" <hujiayu.hu@foxmail.com>,
"Pavan Nikhilesh" <pbhagavatula@marvell.com>,
"Maxime Coquelin" <maxime.coquelin@redhat.com>,
"Chenbo Xia" <chenbox@nvidia.com>
Subject: Re: IPv6 APIs rework
Date: Sat, 20 Jul 2024 13:26:19 -0700 [thread overview]
Message-ID: <20240720132619.4ed7a53a@hermes.local> (raw)
In-Reply-To: <D2UJWNGF7EUI.CQ2GC9HQGRZU@redhat.com>
On Sat, 20 Jul 2024 19:43:45 +0200
"Robin Jarry" <rjarry@redhat.com> wrote:
> Cutting down the quoting a bit.
>
> I understand the arguments against having an unaligned packed struct.
> But it is precisely what we have in the current code base. All IPv6
> addresses are uint8_t[16] arrays. And nobody ever complained about it.
>
> Since this rework is already massive, could we proceed in steps?
>
> First, I can replace all uint8_t[16] arrays by an unaligned packed
> struct which is 99% of the work.
>
> Second, *if there is a real and measurable performance gain*, change
> that structure to remove explicit alignment.
>
> Does this sound like a good plan to everyone?
>
There is no need for packing or alignment in in6_addr or current DPDK,
what would be the benefit? Compilers generate worse code if a structure
is marked packed.
next prev parent reply other threads:[~2024-07-20 20:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-18 15:03 IPv6 APIs rework Robin Jarry
2024-07-18 20:27 ` Morten Brørup
2024-07-18 21:15 ` Stephen Hemminger
2024-07-18 21:40 ` Robin Jarry
2024-07-18 21:25 ` Vladimir Medvedkin
2024-07-18 21:34 ` Robin Jarry
2024-07-19 8:25 ` Konstantin Ananyev
2024-07-19 9:12 ` Morten Brørup
2024-07-19 10:02 ` Robin Jarry
2024-07-19 10:09 ` Bruce Richardson
2024-07-19 10:46 ` Morten Brørup
2024-07-19 11:09 ` Robin Jarry
2024-07-19 15:47 ` Morten Brørup
2024-07-19 17:07 ` Stephen Hemminger
2024-07-20 17:43 ` Robin Jarry
2024-07-20 20:26 ` Stephen Hemminger [this message]
2024-07-20 20:33 ` Robin Jarry
2024-07-21 16:12 ` Morten Brørup
2024-07-21 21:51 ` Robin Jarry
2024-07-22 9:31 ` Morten Brørup
2024-07-19 10:41 ` Medvedkin, Vladimir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240720132619.4ed7a53a@hermes.local \
--to=stephen@networkplumber.org \
--cc=adwivedi@marvell.com \
--cc=ajit.khaparde@broadcom.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=anoobj@marvell.com \
--cc=bharat@chelsio.com \
--cc=bingz@nvidia.com \
--cc=bruce.richardson@intel.com \
--cc=chaoyong.he@corigine.com \
--cc=chas3@att.com \
--cc=chenbox@nvidia.com \
--cc=cloud.wangxiaoyun@huawei.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=dsinghrawat@marvell.com \
--cc=dsosnowski@nvidia.com \
--cc=fanzhang.oss@gmail.com \
--cc=ferruh.yigit@amd.com \
--cc=g.singh@nxp.com \
--cc=gakhil@marvell.com \
--cc=haijie1@huawei.com \
--cc=hemant.agrawal@nxp.com \
--cc=hkalra@marvell.com \
--cc=hujiayu.hu@foxmail.com \
--cc=humin29@huawei.com \
--cc=jianwang@trustnetic.com \
--cc=jiawenwu@trustnetic.com \
--cc=jingjing.wu@intel.com \
--cc=kirankumark@marvell.com \
--cc=konstantin.ananyev@huawei.com \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=ktejasree@marvell.com \
--cc=matan@nvidia.com \
--cc=maxime.coquelin@redhat.com \
--cc=mb@smartsharesystems.com \
--cc=medvedkinv@gmail.com \
--cc=ndabilpuram@marvell.com \
--cc=orika@nvidia.com \
--cc=palok@marvell.com \
--cc=pbhagavatula@marvell.com \
--cc=rjarry@redhat.com \
--cc=rkudurumalla@marvell.com \
--cc=sachin.saxena@nxp.com \
--cc=sameh.gobriel@intel.com \
--cc=skori@marvell.com \
--cc=skoteshwar@marvell.com \
--cc=somnath.kotur@broadcom.com \
--cc=suanmingm@nvidia.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
--cc=wisamm@nvidia.com \
--cc=yipeng1.wang@intel.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.