From: kernel test robot <lkp@intel.com>
To: "Alex Shi (Tencent)" <alexs@kernel.org>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev
Subject: [alexshi:mmunstable 38/38] mm/memory.c:4650:21: error: incompatible pointer types assigning to 'struct ptdesc *' from 'pte_t *'
Date: Sat, 20 Jul 2024 15:35:52 +0800 [thread overview]
Message-ID: <202407201547.3RsdbScA-lkp@intel.com> (raw)
tree: https://github.com/alexshi/linux.git mmunstable
head: b17c1bbf65811ff797f57b7ddc4fdf4b86d86030
commit: b17c1bbf65811ff797f57b7ddc4fdf4b86d86030 [38/38] mm: convert vmf.prealloc_pte to struct ptdesc pointer
config: s390-allnoconfig (https://download.01.org/0day-ci/archive/20240720/202407201547.3RsdbScA-lkp@intel.com/config)
compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project ad154281230d83ee551e12d5be48bb956ef47ed3)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240720/202407201547.3RsdbScA-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202407201547.3RsdbScA-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from mm/memory.c:44:
In file included from include/linux/mm.h:2221:
include/linux/vmstat.h:514:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
514 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
| ~~~~~~~~~~~ ^ ~~~
In file included from mm/memory.c:45:
include/linux/mm_inline.h:47:41: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
47 | __mod_lruvec_state(lruvec, NR_LRU_BASE + lru, nr_pages);
| ~~~~~~~~~~~ ^ ~~~
include/linux/mm_inline.h:49:22: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
49 | NR_ZONE_LRU_BASE + lru, nr_pages);
| ~~~~~~~~~~~~~~~~ ^ ~~~
In file included from mm/memory.c:84:
In file included from arch/s390/include/asm/io.h:93:
include/asm-generic/io.h:548:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
548 | val = __raw_readb(PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:561:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
561 | val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr));
| ~~~~~~~~~~ ^
include/uapi/linux/byteorder/big_endian.h:37:59: note: expanded from macro '__le16_to_cpu'
37 | #define __le16_to_cpu(x) __swab16((__force __u16)(__le16)(x))
| ^
include/uapi/linux/swab.h:102:54: note: expanded from macro '__swab16'
102 | #define __swab16(x) (__u16)__builtin_bswap16((__u16)(x))
| ^
In file included from mm/memory.c:84:
In file included from arch/s390/include/asm/io.h:93:
include/asm-generic/io.h:574:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
574 | val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr));
| ~~~~~~~~~~ ^
include/uapi/linux/byteorder/big_endian.h:35:59: note: expanded from macro '__le32_to_cpu'
35 | #define __le32_to_cpu(x) __swab32((__force __u32)(__le32)(x))
| ^
include/uapi/linux/swab.h:115:54: note: expanded from macro '__swab32'
115 | #define __swab32(x) (__u32)__builtin_bswap32((__u32)(x))
| ^
In file included from mm/memory.c:84:
In file included from arch/s390/include/asm/io.h:93:
include/asm-generic/io.h:585:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
585 | __raw_writeb(value, PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:595:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
595 | __raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:605:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
605 | __raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:693:20: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
693 | readsb(PCI_IOBASE + addr, buffer, count);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:701:20: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
701 | readsw(PCI_IOBASE + addr, buffer, count);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:709:20: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
709 | readsl(PCI_IOBASE + addr, buffer, count);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:718:21: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
718 | writesb(PCI_IOBASE + addr, buffer, count);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:727:21: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
727 | writesw(PCI_IOBASE + addr, buffer, count);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:736:21: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
736 | writesl(PCI_IOBASE + addr, buffer, count);
| ~~~~~~~~~~ ^
mm/memory.c:440:25: error: incompatible pointer types passing 'struct ptdesc *' to parameter of type 'pgtable_t' (aka 'pte_t *') [-Werror,-Wincompatible-pointer-types]
440 | pmd_populate(mm, pmd, *pte);
| ^~~~
arch/s390/include/asm/pgalloc.h:129:27: note: passing argument to parameter 'pte' here
129 | pmd_t *pmd, pgtable_t pte)
| ^
mm/memory.c:448:17: error: incompatible pointer types initializing 'struct ptdesc *' with an expression of type 'pte_t *' [-Werror,-Wincompatible-pointer-types]
448 | struct ptdesc *ptdesc = pte_alloc_one(mm);
| ^ ~~~~~~~~~~~~~~~~~
>> mm/memory.c:4650:21: error: incompatible pointer types assigning to 'struct ptdesc *' from 'pte_t *' [-Werror,-Wincompatible-pointer-types]
4650 | vmf->prealloc_pte = pte_alloc_one(vma->vm_mm);
| ^ ~~~~~~~~~~~~~~~~~~~~~~~~~
mm/memory.c:5013:21: error: incompatible pointer types assigning to 'struct ptdesc *' from 'pte_t *' [-Werror,-Wincompatible-pointer-types]
5013 | vmf->prealloc_pte = pte_alloc_one(vmf->vma->vm_mm);
| ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
15 warnings and 4 errors generated.
vim +4650 mm/memory.c
4622
4623 /*
4624 * The mmap_lock must have been held on entry, and may have been
4625 * released depending on flags and vma->vm_ops->fault() return value.
4626 * See filemap_fault() and __lock_page_retry().
4627 */
4628 static vm_fault_t __do_fault(struct vm_fault *vmf)
4629 {
4630 struct vm_area_struct *vma = vmf->vma;
4631 struct folio *folio;
4632 vm_fault_t ret;
4633
4634 /*
4635 * Preallocate pte before we take page_lock because this might lead to
4636 * deadlocks for memcg reclaim which waits for pages under writeback:
4637 * lock_page(A)
4638 * SetPageWriteback(A)
4639 * unlock_page(A)
4640 * lock_page(B)
4641 * lock_page(B)
4642 * pte_alloc_one
4643 * shrink_folio_list
4644 * wait_on_page_writeback(A)
4645 * SetPageWriteback(B)
4646 * unlock_page(B)
4647 * # flush A, B to clear the writeback
4648 */
4649 if (pmd_none(*vmf->pmd) && !vmf->prealloc_pte) {
> 4650 vmf->prealloc_pte = pte_alloc_one(vma->vm_mm);
4651 if (!vmf->prealloc_pte)
4652 return VM_FAULT_OOM;
4653 }
4654
4655 ret = vma->vm_ops->fault(vmf);
4656 if (unlikely(ret & (VM_FAULT_ERROR | VM_FAULT_NOPAGE | VM_FAULT_RETRY |
4657 VM_FAULT_DONE_COW)))
4658 return ret;
4659
4660 folio = page_folio(vmf->page);
4661 if (unlikely(PageHWPoison(vmf->page))) {
4662 vm_fault_t poisonret = VM_FAULT_HWPOISON;
4663 if (ret & VM_FAULT_LOCKED) {
4664 if (page_mapped(vmf->page))
4665 unmap_mapping_folio(folio);
4666 /* Retry if a clean folio was removed from the cache. */
4667 if (mapping_evict_folio(folio->mapping, folio))
4668 poisonret = VM_FAULT_NOPAGE;
4669 folio_unlock(folio);
4670 }
4671 folio_put(folio);
4672 vmf->page = NULL;
4673 return poisonret;
4674 }
4675
4676 if (unlikely(!(ret & VM_FAULT_LOCKED)))
4677 folio_lock(folio);
4678 else
4679 VM_BUG_ON_PAGE(!folio_test_locked(folio), vmf->page);
4680
4681 return ret;
4682 }
4683
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2024-07-20 7:36 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202407201547.3RsdbScA-lkp@intel.com \
--to=lkp@intel.com \
--cc=alexs@kernel.org \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.