From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE12FC3DA49 for ; Sat, 20 Jul 2024 18:02:15 +0000 (UTC) Received: from mailout4.zoneedit.com (mailout4.zoneedit.com [64.68.198.64]) by mx.groups.io with SMTP id smtpd.web11.10846.1721498526507861503 for ; Sat, 20 Jul 2024 11:02:06 -0700 Authentication-Results: mx.groups.io; dkim=none (message not signed); spf=pass (domain: denix.org, ip: 64.68.198.64, mailfrom: denis@denix.org) Received: from localhost (localhost [127.0.0.1]) by mailout4.zoneedit.com (Postfix) with ESMTP id DE35D40B66; Sat, 20 Jul 2024 18:02:05 +0000 (UTC) Received: from mailout4.zoneedit.com ([127.0.0.1]) by localhost (zmo14-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aiKhtbshvlZX; Sat, 20 Jul 2024 18:02:05 +0000 (UTC) Received: from mail.denix.org (pool-100-15-87-159.washdc.fios.verizon.net [100.15.87.159]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mailout4.zoneedit.com (Postfix) with ESMTPSA id A726840023; Sat, 20 Jul 2024 18:02:01 +0000 (UTC) Received: by mail.denix.org (Postfix, from userid 1000) id C15FB164001; Sat, 20 Jul 2024 14:02:01 -0400 (EDT) Date: Sat, 20 Jul 2024 14:02:01 -0400 From: Denys Dmytriyenko To: reatmon@ti.com Cc: Praneeth Bajjuri , Denys Dmytriyenko , meta-ti@lists.yoctoproject.org Subject: Re: [meta-ti][master][PATCH] libulm: Fix "buildpaths" QA error Message-ID: <20240720180201.GQ17572@denix.org> References: <20240719203603.21930-1-reatmon@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240719203603.21930-1-reatmon@ti.com> User-Agent: Mutt/1.5.20 (2009-06-14) List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Sat, 20 Jul 2024 18:02:15 -0000 X-Groupsio-URL: https://lists.yoctoproject.org/g/meta-ti/message/17900 On Fri, Jul 19, 2024 at 03:36:03PM -0500, Ryan Eatmon via lists.yoctoproject.org wrote: > The TI cl6x compiler does not have a mechanism for replacing paths in > the obj files it creates. So replace the string we want to remove with > an equally sized replacement string that does not contain the path. > > Signed-off-by: Ryan Eatmon > --- > ...m-makefile-Fix-reproducibility-error.patch | 31 +++++++++++++++++++ > .../recipes-bsp/dsptop/libulm_git.bb | 12 +++++-- > 2 files changed, 41 insertions(+), 2 deletions(-) > create mode 100644 meta-ti-extras/recipes-bsp/dsptop/files/0001-dstop-ulm-makefile-Fix-reproducibility-error.patch > > diff --git a/meta-ti-extras/recipes-bsp/dsptop/files/0001-dstop-ulm-makefile-Fix-reproducibility-error.patch b/meta-ti-extras/recipes-bsp/dsptop/files/0001-dstop-ulm-makefile-Fix-reproducibility-error.patch > new file mode 100644 > index 00000000..6ea59517 > --- /dev/null > +++ b/meta-ti-extras/recipes-bsp/dsptop/files/0001-dstop-ulm-makefile-Fix-reproducibility-error.patch > @@ -0,0 +1,31 @@ > +From 8619e4b2f983130bf1909cc9c9bc238cd43ded41 Mon Sep 17 00:00:00 2001 > +From: Ryan Eatmon > +Date: Fri, 19 Jul 2024 14:37:55 -0500 > +Subject: [master][PATCH] dstop/ulm/makefile: Fix reproducibility error > + > +The TI cl6x compiler does not have a mechanism for replacing paths in > +the obj files it creates. So replace the string we want to remove with > +an equally sized replacement string that does not contain the path. > + > +Upstream-Status: Inappropriate [OE-specific] > + > +Signed-off-by: Ryan Eatmon > +--- > + makefile | 1 + > + 1 file changed, 1 insertion(+) > + > +diff --git a/makefile b/makefile > +index dffb211..586dcc2 100644 > +--- a/makefile > ++++ b/makefile > +@@ -82,6 +82,7 @@ $(OBJDIR)/%.obj: %.c $(INCLUDE_FILES) > + @echo "Compiling" $< > + @mkdir -p $(OBJDIR) > + $(CC) $(CFLAGS) $(INCLUDE_PATH) -fe $@ $< > ++ perl -pi -e 's#${SEARCH}#${REPLACE}#g' $@ That assumes perl host tool dependency - is it safe? Can this be done with sed instead? > + > + libtiulm.a libtiulm.ae66: $(OBJECTS) > + @echo "Building target" $@ > +-- > +2.17.1 > + > diff --git a/meta-ti-extras/recipes-bsp/dsptop/libulm_git.bb b/meta-ti-extras/recipes-bsp/dsptop/libulm_git.bb > index 6a2cde30..aafae21f 100644 > --- a/meta-ti-extras/recipes-bsp/dsptop/libulm_git.bb > +++ b/meta-ti-extras/recipes-bsp/dsptop/libulm_git.bb > @@ -6,7 +6,7 @@ inherit features_check > > REQUIRED_MACHINE_FEATURES = "dsp" > > -DEPENDS = "ti-cgt6x-native" > +DEPENDS = "ti-cgt6x-native perl-native" > PR = "${INC_PR}.0" > > S = "${WORKDIR}/git/dsptop/ulm" > @@ -14,7 +14,13 @@ S = "${WORKDIR}/git/dsptop/ulm" > DEVICE="" > DEVICE:dra7xx = "DRA7xx" > > -EXTRA_OEMAKE = "release DEVICE=${DEVICE} CROSS_COMPILE=${TARGET_PREFIX}" > +EXTRA_OEMAKE = " \ > + release \ > + DEVICE=${DEVICE} \ > + CROSS_COMPILE=${TARGET_PREFIX} \ > + SEARCH=${WORKDIR} \ > + REPLACE=${@'_'*(len(d.getVar('WORKDIR'))-7)+"workdir"} \ > +" > > do_compile() { > oe_runmake arm XPORT_ONLY CC="${CC}" > @@ -40,6 +46,8 @@ FILES:${PN}-dev += "\ > > include dsptop.inc > > +SRC_URI += "file://0001-dstop-ulm-makefile-Fix-reproducibility-error.patch" > + > ALLOW_EMPTY:${PN} = "1" > > PARALLEL_MAKE= "" > -- > 2.17.1