Re: [Buildroot] [PATCH v2,1/1] package/gnutls: disable tpm2-tss

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

On Sun, 21 Jul 2024 18:57:17 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Disable tpm2-tss to avoid the following circular dependency if
> BR2_PACKAGE_TPM2_TSS_FAPI is selected:
> tpm2-tss -> libcurl -> gnutls -> tmp2-tss
> resulting in the following build failure of libcurl or rtmpdump since
> commit caff4179a4481233257f5f475ca57ce9061af900:
> 
> configure: error: TLS not detected, you will not be able to use HTTPS, FTPS, NTLM and more.
> Use --with-openssl, --with-gnutls, --with-wolfssl, --with-mbedtls, --with-schannel, --with-secure-transport, --with-amissl, --with-bearssl or --with-rustls to address this.
> 
> [...]
> 
> In file included from rtmp.c:32:
> rtmp_sys.h:110:10: fatal error: gnutls/gnutls.h: No such file or directory
>   110 | #include <gnutls/gnutls.h>
>       |          ^~~~~~~~~~~~~~~~~
> 
> Fixes: caff4179a4481233257f5f475ca57ce9061af900
>  - http://autobuild.buildroot.org/results/72e1843de650c9ed4795f1141e9fd485b71a14c3
>  - http://autobuild.buildroot.org/results/918f0f7efa810b17f6d2266a890bf0150cbed146
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> Changes v1 -> v2 (after review of Baruch Siach):
>  - Add --without-tpm2

I have applied. However, I think it would be nice to add a comment in
the .mk file to explain why we are passing --without-tpm2, to avoid
having someone else re-introduce this optional dependency. Perhaps you
could send a follow-up patch adding that?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot