From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Will Newton <will.newton@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/sysprof: needs headers >= 5.12
Date: Mon, 22 Jul 2024 14:32:01 +0200 [thread overview]
Message-ID: <20240722143201.68c96b59@windsurf> (raw)
In-Reply-To: <20240721165023.1988603-1-fontaine.fabrice@gmail.com>
On Sun, 21 Jul 2024 18:50:23 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> sysprof unconditionally uses PERF_RECORD_MISC_MMAP_BUILD_ID which is
> only available since kernel 5.12 and
> https://github.com/torvalds/linux/commit/88a16a1309333e43d328621ece3e9fa37027e8eb
> resulting in the following build failure with kernel < 5.12 since bump
> to version 46.0 in commit 0d57555407f2a0708515e7c377f57a6466c78b1b:
>
> ../src/libsysprof/sysprof-sampler.c: In function 'sysprof_sampler_perf_event_stream_cb':
> ../src/libsysprof/sysprof-sampler.c:186:33: error: 'PERF_RECORD_MISC_MMAP_BUILD_ID' undeclared (first use in this function); did you mean 'PERF_RECORD_MISC_MMAP_DATA'?
> 186 | if ((event->header.misc & PERF_RECORD_MISC_MMAP_BUILD_ID) != 0)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> | PERF_RECORD_MISC_MMAP_DATA
>
> While at it, also fix a typo in "library"
>
> Fixes: 0d57555407f2a0708515e7c377f57a6466c78b1b
> - http://autobuild.buildroot.org/results/9a9f8462bd1d7127dc80de7f280ab9d100db47fe
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/sysprof/Config.in | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
5.12 is quite "recent", but OK if people care about sysprof on older
kernels, they can provide a patch that allows building sysprof on older
kernels. Applied, thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-07-22 12:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-21 16:50 [Buildroot] [PATCH 1/1] package/sysprof: needs headers >= 5.12 Fabrice Fontaine
2024-07-22 12:32 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240722143201.68c96b59@windsurf \
--to=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=will.newton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.