From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 916D3C3DA5D for ; Mon, 22 Jul 2024 15:01:44 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 1BE5581132; Mon, 22 Jul 2024 15:01:44 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id InOVH5Ef6CCk; Mon, 22 Jul 2024 15:01:43 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 46B75810F9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1721660503; bh=aN125zVdQ7SLatfeeCHT2wg0zEU/dL7GPSULrtUWoQA=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=o4Dt0e9VF7djbjGZ51Vg2TFs19TDu2CdTKafdBErMLUqmf6XqI3UpykRuHZKQkIVn WMzLOxfL+quVYWjiK/cJip+YefN96ngoBfmXgHQ0eSrhBZNW5YRb3e1/Kz5MpXDUHv qffP/msRdkJsBq0y5fs4HSOk8/SnHDHOFRKShRFRjdaXIvBWQ9amvG7ulQY8w5Dwrs dllImhnfLRX7FnTKjHUCDb54IgNyyc+smt2MP3lCvICjjEojQPAgZZJS8bLCewatfv EBpHaPpDxzsMqzix8zAajd5ZaV8Yr2cx2LM/imMp5e/vr5lvhx13VRSoxUR8ET+GLS agTdwrJDQhAtA== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 46B75810F9; Mon, 22 Jul 2024 15:01:43 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id E245D1BF8A8 for ; Mon, 22 Jul 2024 15:01:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id DC749810F9 for ; Mon, 22 Jul 2024 15:01:41 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id mVMytahzO-tn for ; Mon, 22 Jul 2024 15:01:41 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=139.178.84.217; helo=dfw.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org 1B6D7810ED DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 1B6D7810ED Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by smtp1.osuosl.org (Postfix) with ESMTPS id 1B6D7810ED for ; Mon, 22 Jul 2024 15:01:41 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id F1D2560B3E; Mon, 22 Jul 2024 15:01:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 53D61C116B1; Mon, 22 Jul 2024 15:01:38 +0000 (UTC) Date: Mon, 22 Jul 2024 16:01:36 +0100 From: Simon Horman To: Ahmed Zaki Message-ID: <20240722150136.GH715661@kernel.org> References: <20240710204015.124233-1-ahmed.zaki@intel.com> <20240710204015.124233-6-ahmed.zaki@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240710204015.124233-6-ahmed.zaki@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721660499; bh=BGMMpKXqjmnrN8BBfqoHRGbjQcStSiAQC1ZKUqXjJiM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ec6beWYo0z08pgi/2APpB4a2j503wFtcKMaLTYKjvhXNqpSPvMi00eTg32VnLB0Vl G11SQQEJ5HNYUWTe48VES/BkrIyd3M4ZLZ/hm0BMiNHJaF46MABafJyHVvAWR3Zm7i aFEo9zVL7LFbIABa9pkek8wtoQPmK8FmfRBEi1z43AwvL4nTmSR/iFliNfGfQgnOlO HWWpjQbn9Dfim2W2l1KJM9jrDgH1N6iWKEP1WLt/tTbebJjI3XWKgoWmJSz0pUmr7l zHCG1hb0BUtf32GK/7YURBTBPNAVwQWBuJ+cFl5vp9x2UqynORevKL7Pmjixf4p6nC ZJ1aODSgSKYwA== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=none dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=Ec6beWYo Subject: Re: [Intel-wired-lan] [PATCH iwl-next v3 05/13] ice: add parser execution main loop X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, anthony.l.nguyen@intel.com, Marcin Szycik , intel-wired-lan@lists.osuosl.org, Junfeng Guo Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Wed, Jul 10, 2024 at 02:40:07PM -0600, Ahmed Zaki wrote: > From: Junfeng Guo > > Implement the core work of the runtime parser via: > - ice_parser_rt_execute() > - ice_parser_rt_reset() > - ice_parser_rt_pkt_buf_set() > > Reviewed-by: Marcin Szycik > Signed-off-by: Qi Zhang > Signed-off-by: Junfeng Guo > Signed-off-by: Ahmed Zaki > diff --git a/drivers/net/ethernet/intel/ice/ice_parser_rt.c b/drivers/net/ethernet/intel/ice/ice_parser_rt.c ... > +static u16 ice_ptype_resolve(struct ice_parser_rt *rt) > +{ > + struct ice_parser *psr = rt->psr; > + struct ice_ptype_mk_tcam_item *item; nit: Please consider arranging these variables in reverse xmas tree order. Flagged by https://github.com/ecree-solarflare/xmastree > + > + item = ice_ptype_mk_tcam_match(psr->ptype_mk_tcam_table, > + rt->markers, ICE_MARKER_ID_SIZE); > + if (item) > + return item->ptype; > + > + ice_debug(rt->psr->hw, ICE_DBG_PARSER, "Could not resolve PTYPE\n"); > + return U16_MAX; > +} ... From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2703216DEA8 for ; Mon, 22 Jul 2024 15:01:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721660500; cv=none; b=M+A8Oyk7HJ5N1Kbi/YPQ5b9D4mUppOsPczxaLiNVyNf9m0ynMk3gtP7UbbZMMSwjDNAX8sMSHEhydpZPOf32fsUoJ3i6ulxfU1dHEizO8Ac0Xo4W8heCLZISK0+h20ZJg76EeCx6zTnPe3WxEH18fsDcXiloqSaB8bqR3HQDEiE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721660500; c=relaxed/simple; bh=BGMMpKXqjmnrN8BBfqoHRGbjQcStSiAQC1ZKUqXjJiM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PJPjJ92nZ1jWKzCQ692nckJcQGmkZrkR6PUvpBo87W5yDyf3J1kOzpt7H4YvQHiYPOeCnldiGoE/VA+hmoLxlGcgxKB9BHVgyW8JRLfZBln+zjMBoCmLqygTEATcWdJyclYZtNADlAp3tbEll43zJfsp8D/N1KTT8XEYKMGGQfc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Ec6beWYo; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Ec6beWYo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 53D61C116B1; Mon, 22 Jul 2024 15:01:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721660499; bh=BGMMpKXqjmnrN8BBfqoHRGbjQcStSiAQC1ZKUqXjJiM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ec6beWYo0z08pgi/2APpB4a2j503wFtcKMaLTYKjvhXNqpSPvMi00eTg32VnLB0Vl G11SQQEJ5HNYUWTe48VES/BkrIyd3M4ZLZ/hm0BMiNHJaF46MABafJyHVvAWR3Zm7i aFEo9zVL7LFbIABa9pkek8wtoQPmK8FmfRBEi1z43AwvL4nTmSR/iFliNfGfQgnOlO HWWpjQbn9Dfim2W2l1KJM9jrDgH1N6iWKEP1WLt/tTbebJjI3XWKgoWmJSz0pUmr7l zHCG1hb0BUtf32GK/7YURBTBPNAVwQWBuJ+cFl5vp9x2UqynORevKL7Pmjixf4p6nC ZJ1aODSgSKYwA== Date: Mon, 22 Jul 2024 16:01:36 +0100 From: Simon Horman To: Ahmed Zaki Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, anthony.l.nguyen@intel.com, Junfeng Guo , Marcin Szycik Subject: Re: [PATCH iwl-next v3 05/13] ice: add parser execution main loop Message-ID: <20240722150136.GH715661@kernel.org> References: <20240710204015.124233-1-ahmed.zaki@intel.com> <20240710204015.124233-6-ahmed.zaki@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240710204015.124233-6-ahmed.zaki@intel.com> On Wed, Jul 10, 2024 at 02:40:07PM -0600, Ahmed Zaki wrote: > From: Junfeng Guo > > Implement the core work of the runtime parser via: > - ice_parser_rt_execute() > - ice_parser_rt_reset() > - ice_parser_rt_pkt_buf_set() > > Reviewed-by: Marcin Szycik > Signed-off-by: Qi Zhang > Signed-off-by: Junfeng Guo > Signed-off-by: Ahmed Zaki > diff --git a/drivers/net/ethernet/intel/ice/ice_parser_rt.c b/drivers/net/ethernet/intel/ice/ice_parser_rt.c ... > +static u16 ice_ptype_resolve(struct ice_parser_rt *rt) > +{ > + struct ice_parser *psr = rt->psr; > + struct ice_ptype_mk_tcam_item *item; nit: Please consider arranging these variables in reverse xmas tree order. Flagged by https://github.com/ecree-solarflare/xmastree > + > + item = ice_ptype_mk_tcam_match(psr->ptype_mk_tcam_table, > + rt->markers, ICE_MARKER_ID_SIZE); > + if (item) > + return item->ptype; > + > + ice_debug(rt->psr->hw, ICE_DBG_PARSER, "Could not resolve PTYPE\n"); > + return U16_MAX; > +} ...