Re: [PATCH v3 2/2] dma: add IOMMU static calls with clear default ops

[Christoph Hellwig <hch@lst.de>]

On Sun, Jul 21, 2024 at 10:49:11AM +0300, Leon Romanovsky wrote:
> -static void iommu_dma_free_noncontiguous(struct device *dev, size_t size,
> -		struct sg_table *sgt, enum dma_data_direction dir)
> +void iommu_dma_free_noncontiguous(struct device *dev, size_t size,
> +				  struct sg_table *sgt,
> +				  enum dma_data_direction dir)

Why are you reformatting these to a much less readable coding style?

> +static inline struct page *
> +dma_common_alloc_pages(struct device *dev, size_t size, dma_addr_t *dma_handle,
> +		       enum dma_data_direction dir, gfp_t gfp)
> +{
> +	return NULL;
> +}
> +static inline void dma_common_free_pages(struct device *dev, size_t size,
> +					 struct page *vaddr,
> +					 dma_addr_t dma_handle,
> +					 enum dma_data_direction dir)
> +{
> +}

dma-iommu very much depends on these.  So we'll need to also
build ops_helpers.o if dma-iommu is enabled.  So we'll probably need
a separate Kconfig option for it that the various users select.