From: "Theodore Ts'o" <tytso@mit.edu>
To: Kees Cook <kees@kernel.org>
Cc: "Darrick J. Wong" <djwong@kernel.org>,
"Artem S. Tashkinov" <aros@gmx.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-ext4@vger.kernel.org, xcreativ@gmail.com,
madeisbaer@arcor.de, justinstitt@google.com,
keescook@chromium.org, linux-hardening@vger.kernel.org
Subject: Re: Linux 6.10 regression resulting in a crash when using an ext4 filesystem
Date: Tue, 23 Jul 2024 00:11:36 -0400 [thread overview]
Message-ID: <20240723041136.GC3222663@mit.edu> (raw)
In-Reply-To: <BEEA84E0-1CF5-4F06-BC5C-A0F97240D76D@kernel.org>
On Mon, Jul 22, 2024 at 12:06:59AM -0700, Kees Cook wrote:
> >Is strscpy_pad appropriate if the @src parameter itself is a fixed
> >length char[16] which isn't null terminated when the label itself is 16
> >chars long?
>
> Nope; it needed memtostr_pad(). I sent the fix back at the end of May, but it only just recently landed:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=be27cd64461c45a6088a91a04eba5cd44e1767ef
Yeah, sorry, I was on vacation for 3.5 weeks starting just before
Memorial day, and it took me a while to get caught up. Unfortunately,
I missed the bug in the strncpy extirpation patch, and it was't
something that our regression tests caught. (Sometimes, the
old/deprecated ways are just more reliable; all of ext4's strncpy()
calls were working and had been correct for decades. :-P )
Anyway, Kees's bugfix is in Linus's tree, and it should be shortly be
making its way to -stable.
- Ted
next prev parent reply other threads:[~2024-07-23 4:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-21 21:10 Linux 6.10 regression resulting in a crash when using an ext4 filesystem Artem S. Tashkinov
2024-07-22 4:19 ` Darrick J. Wong
2024-07-22 7:06 ` Kees Cook
2024-07-23 4:11 ` Theodore Ts'o [this message]
2024-07-23 10:04 ` Thorsten Leemhuis
2024-07-23 11:14 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240723041136.GC3222663@mit.edu \
--to=tytso@mit.edu \
--cc=aros@gmx.com \
--cc=djwong@kernel.org \
--cc=justinstitt@google.com \
--cc=kees@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=madeisbaer@arcor.de \
--cc=xcreativ@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.