Re: [Buildroot] [PATCH 1/1] package/cwiid: fix build with gcc >= 14

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Samuel Martin <s.martin49@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/cwiid: fix build with gcc >= 14
Date: Tue, 23 Jul 2024 10:54:08 +0200	[thread overview]
Message-ID: <20240723105408.18dd49bf@windsurf> (raw)
In-Reply-To: <20240723083608.701739-1-fontaine.fabrice@gmail.com>

Hello Fabrice,

On Tue, 23 Jul 2024 10:36:08 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> +diff --git a/wminput/plugins/led/led.c b/wminput/plugins/led/led.c
> +index 93b96d9..723a2db 100644
> +--- a/wminput/plugins/led/led.c
> ++++ b/wminput/plugins/led/led.c
> +@@ -83,7 +83,7 @@ struct wmplugin_data *wmplugin_exec(int mesg_count, union cwiid_mesg mesg[])
> + 		btn_mesg = NULL;
> + 		for (i=0; i < mesg_count; i++) {
> + 			if (mesg[i].type == CWIID_MESG_BTN) {
> +-				btn_mesg = &mesg[i].btn_mesg;
> ++				btn_mesg = (struct cwiid_btn_message *) &mesg[i].btn_mesg;
> + 				button = mesg[i].btn_mesg.buttons;

Thanks for looking into this. However, do you have some evidence that
it is correct to cast cabbage into carrots?

I.e, why is it correct to cast a struct cwiid_btn_mesg into a struct
cwiid_btn_message ?

Thanks,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot